Hello,


On 09/21/2015 02:26 PM, Sripada, Radhakrishna wrote:
> intel_idle driver exposes the sates C1-SKL and C1E-SKL. Powertop Idle Stats only show the statistics of C1E-SKL and not C1-SKL. By parsing the human name for the two states, the same line level '1' gets assigned to both C1-SKL and C1E-SKL. Hence the statistics of C1-SKL are always overwritten by the statistics of C1E-SKL. To eliminate this parsing linux name would assign different line levels to different cstates irrespective of their human names.
>
> -----Original Message-----
> From: Arjan van de Ven [mailto:arjan(a)linux.intel.com]
> Sent: Monday, September 21, 2015 12:49 PM
> To: Sripada, Radhakrishna; powertop(a)lists.01.org
> Subject: Re: [Powertop] [PATCH] Assign line level based on linux name
>
> On 9/21/2015 11:34 AM, Radhakrishna Sripada wrote:
>> C-states having the same number in their human names have the same
>> line levels. Switching to linux names assigns seperate levels to each C-state.
>>
>> Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada(a)intel.com>
>
> hmm do you have a before/after kind of thing?
> (your description is a bit cryptic in that sense)
>
> also of course this code isn't used for Intel cpus normally...
>
>
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
>

Does anyone from the ARM community have an issue with this patch?

RD,
Please re-send your patch with a more clear description on what the 
patch fixes.  like you do in this message.

-- 
Thank you,
<Alexandra>