All of lore.kernel.org
 help / color / mirror / Atom feed
From: Razvan Cojocaru <rzvncj@...277...>
To: Selva Nair <selva.nair@...277...>
Cc: Gert Doering <gert@...1296...>, openvpn-devel@lists.sourceforge.net
Subject: Re: [Openvpn-devel] [PATCH] Allow setting an empty auth-token in push replies
Date: Wed, 23 Oct 2024 18:48:11 +0300	[thread overview]
Message-ID: <56038512-a84a-4bb7-a1e0-38a0d4f99b70@...277...> (raw)
In-Reply-To: <CAKuzo_ifn6ma288DdFNm_=AURyU+uneuxo5HWuB6FHXTCDpVrQ@...278...>

On 10/23/24 18:25, Selva Nair wrote:
> Wouldn't pushing "HALT" instead of "AUTH_FAILED" work in this case?
> As in the management command "client-kill {cid} HALT" which calls
> send_restart() with kill_msg = "HALT".

Possibly, however the intent has always been to use this feature to 
reject (authorize) clients (so this is a corner case of that, just that 
we can retract authorization at a later time), and in addition 
considerable work has already been done that relies on the AUTH_FAILED 
code paths.


Thanks,
Razvan


  reply	other threads:[~2024-10-23 15:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23 13:49 [Openvpn-devel] [PATCH] Allow setting an empty auth-token in push replies Razvan Cojocaru
2024-10-23 14:23 ` Gert Doering
2024-10-23 14:40   ` Razvan Cojocaru
2024-10-23 14:43     ` Gert Doering
2024-10-23 14:47       ` Razvan Cojocaru
2024-10-23 14:50         ` Gert Doering
2024-10-23 15:01           ` Razvan Cojocaru
2024-10-23 15:25             ` Selva Nair
2024-10-23 15:48               ` Razvan Cojocaru [this message]
2024-10-23 16:27                 ` Selva Nair

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56038512-a84a-4bb7-a1e0-38a0d4f99b70@...277... \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.