From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756533AbbIXGxp (ORCPT ); Thu, 24 Sep 2015 02:53:45 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:26034 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751547AbbIXGxo (ORCPT ); Thu, 24 Sep 2015 02:53:44 -0400 Message-ID: <56039DE6.5020904@huawei.com> Date: Thu, 24 Sep 2015 14:53:26 +0800 From: Weidong Wang User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: David Miller CC: , , , , Subject: Re: [PATCH net-next] BNX2: fix a Null Pointer for stats_blk References: <56014CC0.3050201@huawei.com> <20150923.153117.2291008783799112683.davem@davemloft.net> <5603594D.70408@huawei.com> <20150923.223436.53190852255282400.davem@davemloft.net> In-Reply-To: <20150923.223436.53190852255282400.davem@davemloft.net> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.21.100] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/9/24 13:34, David Miller wrote: > From: Weidong Wang > Date: Thu, 24 Sep 2015 10:00:45 +0800 > >> It does affect the intention. Although, the problem exists then makes the >> system panic within some case. >> >> Do you have any idea about it? > > Allocate the statistics block at probe time so that this problem is > impossible. > It is a good idea. Yet, what is the intention of the dynamic to alloc/free stats_block? what will be affected by allocating the statistics block. Best Regards, Weidong >