All of lore.kernel.org
 help / color / mirror / Atom feed
From: Panu Matilainen <pmatilai@redhat.com>
To: dev@dpdk.org
Subject: Re: [PATCH 2/3] scripts: move two identical config fixups into a function
Date: Thu, 24 Sep 2015 10:42:27 +0300	[thread overview]
Message-ID: <5603A963.9000908@redhat.com> (raw)
In-Reply-To: <e78cc50cd33b64d8d6fcc4b7f8be45189ce4f558.1443079633.git.pmatilai@redhat.com>

On 09/24/2015 10:34 AM, Panu Matilainen wrote:

>   # Checking abi compliance relies on using the dwarf information in
>   # The shared objects.  Thats only included in the DSO's if we build
> @@ -167,6 +171,8 @@ sed -i -e"$ a\CONFIG_RTE_LIBRTE_KNI=n" config/defconfig_$TARGET
>   export EXTRA_CFLAGS="$EXTRA_CFLAGS -g"
>   export EXTRA_LDFLAGS="$EXTRA_LDFLAGS -g"
>
> +fixup_config
> +
>   # Now configure the build
>   log "INFO" "Configuring DPDK $TAG1"
>   make config T=$TARGET O=$TARGET > $VERBOSE 2>&1
> @@ -196,13 +202,6 @@ git reset --hard
>   log "INFO" "Checking out version $TAG2 of the dpdk"
>   git checkout $TAG2
>
> -# Make sure we configure SHARED libraries
> -# Also turn off IGB and KNI as those require kernel headers to build
> -sed -i -e"$ a\CONFIG_RTE_BUILD_SHARED_LIB=y" config/defconfig_$TARGET
> -sed -i -e"$ a\CONFIG_RTE_NEXT_ABI=n" config/defconfig_$TARGET
> -sed -i -e"$ a\CONFIG_RTE_EAL_IGB_UIO=n" config/defconfig_$TARGET
> -sed -i -e"$ a\CONFIG_RTE_LIBRTE_KNI=n" config/defconfig_$TARGET
> -

Doh. Obvious brain damage here, will send v2 after fetching apparently 
needed additional coffee.

	- Panu -

  reply	other threads:[~2015-09-24  7:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-24  7:34 [PATCH 0/3] Minor abi-validator improvements Panu Matilainen
2015-09-24  7:34 ` [PATCH 1/3] scripts: permit passing extra compiler & linker flags to ABI validator Panu Matilainen
2015-09-24  7:34 ` [PATCH 2/3] scripts: move two identical config fixups into a function Panu Matilainen
2015-09-24  7:42   ` Panu Matilainen [this message]
2015-09-24  7:34 ` [PATCH 3/3] scripts: teach ABI validator about CONFIG_RTE_KNI_KMOD Panu Matilainen
2015-09-24  7:50 ` [PATCH 0/3 v2] Minor abi-validator improvements Panu Matilainen
2015-09-24  7:50   ` [PATCH 1/3] scripts: permit passing extra compiler & linker flags to ABI validator Panu Matilainen
2015-09-24  7:50   ` [PATCH 2/3] scripts: move two identical config fixups into a function Panu Matilainen
2015-09-24  7:50   ` [PATCH 3/3] scripts: teach ABI validator about CONFIG_RTE_KNI_KMOD Panu Matilainen
2015-09-24 10:23   ` [PATCH 0/3 v2] Minor abi-validator improvements Neil Horman
2015-11-11  7:07     ` Panu Matilainen
2015-11-11 10:16       ` Thomas Monjalon
2015-11-11 10:24         ` Panu Matilainen
2015-12-03 19:38     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5603A963.9000908@redhat.com \
    --to=pmatilai@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.