From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49978) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zf1m6-00029d-M8 for qemu-devel@nongnu.org; Thu, 24 Sep 2015 04:21:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zf1m2-0002nh-NO for qemu-devel@nongnu.org; Thu, 24 Sep 2015 04:21:06 -0400 Received: from [59.151.112.132] (port=28294 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zf1m1-0002Yo-O1 for qemu-devel@nongnu.org; Thu, 24 Sep 2015 04:21:02 -0400 Message-ID: <5603B261.4060105@cn.fujitsu.com> Date: Thu, 24 Sep 2015 16:20:49 +0800 From: Yang Hongyang MIME-Version: 1.0 References: <1443079333-30097-1-git-send-email-thuth@redhat.com> <1443079333-30097-5-git-send-email-thuth@redhat.com> In-Reply-To: <1443079333-30097-5-git-send-email-thuth@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/5] net/dump: Provide the dumping facility as a net filter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , qemu-devel@nongnu.org, jasowang@redhat.com Cc: armbru@redhat.com, stefanha@redhat.com, mst@redhat.com The filter interface part looks good to me, thanks! On 09/24/2015 03:22 PM, Thomas Huth wrote: > Use the net filter infrastructure to provide the dumping > functions for netdev devices, too. > > Signed-off-by: Thomas Huth > --- > net/dump.c | 129 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- > vl.c | 8 +++- > 2 files changed, 134 insertions(+), 3 deletions(-) > > diff --git a/net/dump.c b/net/dump.c > index afff78e..5904f58 100644 > --- a/net/dump.c > +++ b/net/dump.c > @@ -28,7 +28,8 @@ > #include "qemu/iov.h" > #include "qemu/log.h" > #include "qemu/timer.h" > -#include "hub.h" > +#include "qapi/visitor.h" > +#include "net/filter.h" > > typedef struct DumpState { > int64_t start_ts; > @@ -225,3 +226,129 @@ int net_init_dump(const NetClientOptions *opts, const char *name, > } > return rc; > } > + > +/* Dumping via filter */ > + > +#define TYPE_FILTER_DUMP "filter-dump" > + > +#define FILTER_DUMP(obj) \ > + OBJECT_CHECK(NetFilterDumpState, (obj), TYPE_FILTER_DUMP) > + > +struct NetFilterDumpState { > + NetFilterState nfs; > + DumpState ds; > + char *filename; > + uint32_t maxlen; > +}; > +typedef struct NetFilterDumpState NetFilterDumpState; > + > +static ssize_t filter_dump_receive_iov(NetFilterState *nf, NetClientState *sndr, > + unsigned flags, const struct iovec *iov, > + int iovcnt, NetPacketSent *sent_cb) > +{ > + NetFilterDumpState *nfds = FILTER_DUMP(nf); > + > + dump_receive_iov(&nfds->ds, iov, iovcnt); > + return 0; > +} > + > +static void filter_dump_cleanup(NetFilterState *nf) > +{ > + NetFilterDumpState *nfds = FILTER_DUMP(nf); > + > + dump_cleanup(&nfds->ds); > +} > + > +static void filter_dump_setup(NetFilterState *nf, Error **errp) > +{ > + NetFilterDumpState *nfds = FILTER_DUMP(nf); > + > + if (!nfds->filename) { > + error_setg(errp, "dump filter needs 'file' property set!"); > + return; > + } > + > + net_dump_state_init(&nfds->ds, nfds->filename, nfds->maxlen, errp); > +} > + > +static void filter_dump_get_maxlen(Object *obj, Visitor *v, void *opaque, > + const char *name, Error **errp) > +{ > + NetFilterDumpState *nfds = FILTER_DUMP(obj); > + uint32_t value = nfds->maxlen; > + > + visit_type_uint32(v, &value, name, errp); > +} > + > +static void filter_dump_set_maxlen(Object *obj, Visitor *v, void *opaque, > + const char *name, Error **errp) > +{ > + NetFilterDumpState *nfds = FILTER_DUMP(obj); > + Error *local_err = NULL; > + uint32_t value; > + > + visit_type_uint32(v, &value, name, &local_err); > + if (local_err) { > + goto out; > + } > + if (value == 0) { > + error_setg(&local_err, "Property '%s.%s' doesn't take value '%u'", > + object_get_typename(obj), name, value); > + goto out; > + } > + nfds->maxlen = value; > + > +out: > + error_propagate(errp, local_err); > +} > + > +static char *file_dump_get_filename(Object *obj, Error **errp) > +{ > + NetFilterDumpState *nfds = FILTER_DUMP(obj); > + > + return g_strdup(nfds->filename); > +} > + > +static void file_dump_set_filename(Object *obj, const char *value, Error **errp) > +{ > + NetFilterDumpState *nfds = FILTER_DUMP(obj); > + > + g_free(nfds->filename); > + nfds->filename = g_strdup(value); > +} > + > +static void filter_dump_instance_init(Object *obj) > +{ > + NetFilterDumpState *nfds = FILTER_DUMP(obj); > + > + nfds->maxlen = 65536; > + > + object_property_add(obj, "maxlen", "int", filter_dump_get_maxlen, > + filter_dump_set_maxlen, NULL, NULL, NULL); > + object_property_add_str(obj, "file", file_dump_get_filename, > + file_dump_set_filename, NULL); > +} > + > +static void filter_dump_class_init(ObjectClass *oc, void *data) > +{ > + NetFilterClass *nfc = NETFILTER_CLASS(oc); > + > + nfc->setup = filter_dump_setup; > + nfc->cleanup = filter_dump_cleanup; > + nfc->receive_iov = filter_dump_receive_iov; > +} > + > +static const TypeInfo filter_dump_info = { > + .name = TYPE_FILTER_DUMP, > + .parent = TYPE_NETFILTER, > + .class_init = filter_dump_class_init, > + .instance_init = filter_dump_instance_init, > + .instance_size = sizeof(NetFilterDumpState), > +}; > + > +static void filter_dump_register_types(void) > +{ > + type_register_static(&filter_dump_info); > +} > + > +type_init(filter_dump_register_types); > diff --git a/vl.c b/vl.c > index 9be4d22..aa99ef3 100644 > --- a/vl.c > +++ b/vl.c > @@ -2761,8 +2761,12 @@ static bool object_create_initial(const char *type) > return false; > } > > - /* return false for concrete netfilters */ > - if (g_str_equal(type, "filter-buffer")) { > + /* > + * return false for concrete netfilters since > + * they depend on netdevs already existing > + */ > + if (g_str_equal(type, "filter-buffer") || > + g_str_equal(type, "filter-dump")) { > return false; > } > > -- Thanks, Yang.