From: Boaz Harrosh <boaz@plexistor.com>
To: Dave Chinner <david@fromorbit.com>,
Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm <linux-nvdimm@ml01.01.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCH v2] dax: fix NULL pointer in __dax_pmd_fault()
Date: Thu, 24 Sep 2015 11:50:00 +0300 [thread overview]
Message-ID: <5603B938.1@plexistor.com> (raw)
In-Reply-To: <20150923090459.GO19114@dastard>
On 09/23/2015 12:04 PM, Dave Chinner wrote:
> On Tue, Sep 22, 2015 at 08:00:29PM -0700, Dan Williams wrote:
<>
>> The kaddr is coming from the devm_memremap() in the pmem driver that
>> gets unmapped after the device is released by the driver.
>
> Perhaps the better solution is to not tear down the block device
> until all active references have gone away? i.e. unbind puts the
> device into a persistent error state and forces all active mappings
> to refault. Hence all future accesses error out and then when the
> user unmounts the unhappy filesystem the last reference to the
> blockdev goes away and the mappings can be torn down safely...
>
Me too
> Cheers,
>
> Dave.
>
next prev parent reply other threads:[~2015-09-24 8:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 19:36 [PATCH v2] dax: fix NULL pointer in __dax_pmd_fault() Ross Zwisler
2015-09-22 19:36 ` Ross Zwisler
2015-09-22 20:51 ` Dan Williams
2015-09-22 20:51 ` Dan Williams
2015-09-22 20:51 ` Dan Williams
2015-09-22 21:17 ` Ross Zwisler
2015-09-22 21:26 ` Dan Williams
2015-09-22 21:26 ` Dan Williams
2015-09-22 21:26 ` Dan Williams
2015-09-22 21:13 ` Andrew Morton
2015-09-22 21:25 ` Dan Williams
2015-09-22 23:30 ` Dave Chinner
2015-09-23 3:00 ` Dan Williams
2015-09-23 9:04 ` Dave Chinner
2015-09-24 8:50 ` Boaz Harrosh [this message]
2015-09-24 16:06 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5603B938.1@plexistor.com \
--to=boaz@plexistor.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.