From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 3/5] drm: omapdrm: tiler: Fix module autoload for OF platform driver Date: Thu, 24 Sep 2015 13:41:56 +0300 Message-ID: <5603D374.3010806@ti.com> References: <20150917142146.GA20176@goodgumbo.baconseed.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0804728080==" Return-path: Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7AE296E5AA for ; Thu, 24 Sep 2015 03:42:06 -0700 (PDT) In-Reply-To: <20150917142146.GA20176@goodgumbo.baconseed.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Luis de Bethencourt , linux-kernel@vger.kernel.org Cc: Grygorii Strashko , Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0804728080== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="i1uoxTXrfP2lUVSfXbmCILcaNLKS3N6o5" --i1uoxTXrfP2lUVSfXbmCILcaNLKS3N6o5 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 17/09/15 17:21, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. >=20 > Signed-off-by: Luis de Bethencourt > --- > drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm= /omapdrm/omap_dmm_tiler.c > index 7841970..ecbc9e5 100644 > --- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c > +++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c > @@ -1014,6 +1014,7 @@ static const struct of_device_id dmm_of_match[] =3D= { > }, > {}, > }; > +MODULE_DEVICE_TABLE(of, dmm_of_match); > #endif > =20 > struct platform_driver omap_dmm_driver =3D { I think this one is not needed. Tiler cannot be compiled as a module. Or, to be more exact, the tiler driver is included in the omapdrm module, along with the main omapdrm driver, which can be a module. The autoloading should happen via omapdrm, and when that happens, tiler driver comes along. Tomi --i1uoxTXrfP2lUVSfXbmCILcaNLKS3N6o5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWA9N0AAoJEPo9qoy8lh71yJAP/0X9JqW+9lXtGzmiAdbN9qNm h1+uQujs3CMM3zvFVfCxLjcSJoZ5TlcnlOewvtGhi0hNpoaisusM1SFS7eHOUEo0 MVFKYOXmQ7HRGmz7tDsfvBRi022Tcei3rKezy1xRGkLB18lY0hXQ5Ea0EnG0xIsd V7kocYgyFTHO2Eb8Tx/fitUBVVn3lM4POg2/x+G8NUZ1vAqtPglci27YZaFsd+wy IhQo6fldA/ZaUH6MdLQkOSs/kvFVJ1e4RqRZPyRfZruRCZo3X/7Z0gqE+mtZrqPj 9nne2OeG4wvY3U5xJvMt3G/xb+MdpFw5vR7x2qE0gsvQtnoxEpj7XfuGYTWrmpuN xs1WNH+/i1UDlpdPq5nd5Fx3FP0RIPip914adPv8Ijzo2BPI8PAHZp9abiLR5Eq+ PqKWS+E3z+UEM7GxPWZUnDqoXDpPakFObkJHwxOCRAd4yu3j35NnP0Z3wEs9a9Bq cZBxlyhokUcLcQtw9k8XNS1LdhcpfvNCfts9766L/VBYKpjbdBZbEBw1C5jCLprC /DcyfdusQrzwQhVTpBLFPHxhbaUTgUgsw0BIqxXvJwwbRKkkCbS1QX2ZFtY1PU59 aPXQpznEwvLNdxo3IkVqfs0CPiSEKFzp15OGgbhjUb37n5Yiow6P2NQifQuz5I1p 6753O1mdJ5wsG0ocWGZ6 =HnA/ -----END PGP SIGNATURE----- --i1uoxTXrfP2lUVSfXbmCILcaNLKS3N6o5-- --===============0804728080== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0804728080==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752622AbbIXKmJ (ORCPT ); Thu, 24 Sep 2015 06:42:09 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:51970 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751073AbbIXKmH (ORCPT ); Thu, 24 Sep 2015 06:42:07 -0400 Subject: Re: [PATCH 3/5] drm: omapdrm: tiler: Fix module autoload for OF platform driver To: Luis de Bethencourt , References: <20150917142146.GA20176@goodgumbo.baconseed.org> CC: David Airlie , Laurent Pinchart , Grygorii Strashko , Rob Clark , From: Tomi Valkeinen X-Enigmail-Draft-Status: N1110 Message-ID: <5603D374.3010806@ti.com> Date: Thu, 24 Sep 2015 13:41:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150917142146.GA20176@goodgumbo.baconseed.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="i1uoxTXrfP2lUVSfXbmCILcaNLKS3N6o5" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --i1uoxTXrfP2lUVSfXbmCILcaNLKS3N6o5 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 17/09/15 17:21, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. >=20 > Signed-off-by: Luis de Bethencourt > --- > drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm= /omapdrm/omap_dmm_tiler.c > index 7841970..ecbc9e5 100644 > --- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c > +++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c > @@ -1014,6 +1014,7 @@ static const struct of_device_id dmm_of_match[] =3D= { > }, > {}, > }; > +MODULE_DEVICE_TABLE(of, dmm_of_match); > #endif > =20 > struct platform_driver omap_dmm_driver =3D { I think this one is not needed. Tiler cannot be compiled as a module. Or, to be more exact, the tiler driver is included in the omapdrm module, along with the main omapdrm driver, which can be a module. The autoloading should happen via omapdrm, and when that happens, tiler driver comes along. Tomi --i1uoxTXrfP2lUVSfXbmCILcaNLKS3N6o5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWA9N0AAoJEPo9qoy8lh71yJAP/0X9JqW+9lXtGzmiAdbN9qNm h1+uQujs3CMM3zvFVfCxLjcSJoZ5TlcnlOewvtGhi0hNpoaisusM1SFS7eHOUEo0 MVFKYOXmQ7HRGmz7tDsfvBRi022Tcei3rKezy1xRGkLB18lY0hXQ5Ea0EnG0xIsd V7kocYgyFTHO2Eb8Tx/fitUBVVn3lM4POg2/x+G8NUZ1vAqtPglci27YZaFsd+wy IhQo6fldA/ZaUH6MdLQkOSs/kvFVJ1e4RqRZPyRfZruRCZo3X/7Z0gqE+mtZrqPj 9nne2OeG4wvY3U5xJvMt3G/xb+MdpFw5vR7x2qE0gsvQtnoxEpj7XfuGYTWrmpuN xs1WNH+/i1UDlpdPq5nd5Fx3FP0RIPip914adPv8Ijzo2BPI8PAHZp9abiLR5Eq+ PqKWS+E3z+UEM7GxPWZUnDqoXDpPakFObkJHwxOCRAd4yu3j35NnP0Z3wEs9a9Bq cZBxlyhokUcLcQtw9k8XNS1LdhcpfvNCfts9766L/VBYKpjbdBZbEBw1C5jCLprC /DcyfdusQrzwQhVTpBLFPHxhbaUTgUgsw0BIqxXvJwwbRKkkCbS1QX2ZFtY1PU59 aPXQpznEwvLNdxo3IkVqfs0CPiSEKFzp15OGgbhjUb37n5Yiow6P2NQifQuz5I1p 6753O1mdJ5wsG0ocWGZ6 =HnA/ -----END PGP SIGNATURE----- --i1uoxTXrfP2lUVSfXbmCILcaNLKS3N6o5--