From: Wengang Wang <wen.gang.wang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] IB/mlx4: Use vmalloc for WR buffers when needed
Date: Thu, 24 Sep 2015 18:46:41 +0800 [thread overview]
Message-ID: <5603D491.8050702@oracle.com> (raw)
In-Reply-To: <5603AF26.9040403-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
在 2015年09月24日 16:07, Or Gerlitz 写道:
> On 9/24/2015 9:52 AM, Wengang Wang wrote:
>> } else {
>> - kfree(qp->sq.wrid);
>> - kfree(qp->rq.wrid);
>> + if (is_vmalloc_addr(qp->sq.wrid))
>> + vfree(qp->sq.wrid);
>> + else
>> + kfree(qp->sq.wrid);
>> +
>> + if (is_vmalloc_addr(qp->rq.wrid))
>> + vfree(qp->rq.wrid);
>> + else
>> + kfree(qp->rq.wrid);
>> }
>
> NO
>
> just call kvfree, see commit 914efb0 "mlx4: don't duplicate kvfree()"
Yeap, will re-post.
thanks,
wengang
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-09-24 10:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 6:52 [PATCH] IB/mlx4: Use vmalloc for WR buffers when needed Wengang Wang
[not found] ` <1443077547-12246-1-git-send-email-wen.gang.wang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-09-24 8:07 ` Or Gerlitz
[not found] ` <5603AF26.9040403-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-09-24 10:46 ` Wengang Wang [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-09-24 10:49 Wengang Wang
[not found] ` <1443091747-13881-1-git-send-email-wen.gang.wang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-09-24 11:57 ` Or Gerlitz
[not found] ` <CAJ3xEMgN4_gk4_hVXOW2GhcfnXxgPnm=Lrc7JwkxBAeKv4KRAQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-25 0:51 ` Wengang Wang
[not found] ` <56049A8A.6040101-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-10-08 6:06 ` Leon Romanovsky
[not found] ` <20151008060609.GA19101-2ukJVAZIZ/Y@public.gmane.org>
2015-10-08 6:14 ` Or Gerlitz
[not found] ` <561609D9.2080404-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-10-08 6:25 ` Leon Romanovsky
2015-10-08 5:10 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5603D491.8050702@oracle.com \
--to=wen.gang.wang-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.