From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v2] xen/keyhandler: Rework keyhandler
	infrastructure
Date: Thu, 24 Sep 2015 11:47:02 +0100
Message-ID: <5603D4A6.7060106@citrix.com>
References: <1443023707-8803-1-git-send-email-andrew.cooper3@citrix.com>
	<5603E80402000078000A5323@prv-mh.provo.novell.com>
	<5603D22E.2020002@citrix.com>
	<5603EFE502000078000A535C@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5603EFE502000078000A535C@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 24/09/15 11:43, Jan Beulich wrote:
>>>> On 24.09.15 at 12:36, <andrew.cooper3@citrix.com> wrote:
>>>> +void register_irq_keyhandler(unsigned char key,
>>>> +                             irq_keyhandler_fn_t *fn,
>>>> +                             const char *desc,
>>>> +                             bool_t diagnostic);
>>> I wonder whether the last parameter is really useful here.
>> Yes.  There are diagnostic irq_keyhandlers, 'd' for example.
> I know; I was wondering if we would ever reasonably gain ones
> outside of keyhandler.c.

I am not sure, but as I said, it should be present for completeness.  
The extra incurred overhead is not an issue.

~Andrew