Re: [Qemu-devel] [PATCH v3] docs: describe the QEMU build system structure / design

[Laszlo Ersek <lersek@redhat.com>]

On 09/24/15 11:49, Daniel P. Berrange wrote:
> Developers who are new to QEMU, or have a background familiarity
> with GNU autotools, can have trouble getting their head around the
> home-grown QEMU build system. This document attempts to explain
> the structure / design of the configure script and the various
> Makefile pieces that live across the source tree.
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> 
> Changed in v3:
> 
>  - More speling eror fixes
>  - Rephrased more paragraphs as suggested
> 
> Changed in v2:
> 
>  - Misc speling eror fixes
>  - Rephrased some paragraphs as suggested
>  - Added note about config-host.h file generation & use
> 
>  docs/build-system.txt | 507 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 507 insertions(+)
>  create mode 100644 docs/build-system.txt

Diffed this against v2; I have only one comment:

> +the userspace emulator targets as the global $(LIBS), or more targetted

This is new in v3, and it seems to reintroduce the (otherwise correct
en_GB?) spelling of "targetted". If I recall correctly, it has been
suggested to spell it as "targeted" (and that form can in fact be found
in the same paragraph).

Otherwise, ACK.

Thanks
Laszlo