From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v7 23/28] xen/arm: ITS: Allocate pending_lpi descriptors for LPIs Date: Thu, 24 Sep 2015 13:38:04 +0100 Message-ID: <5603EEAC.9050203@citrix.com> References: <1442581755-2668-1-git-send-email-vijay.kilari@gmail.com> <1442581755-2668-24-git-send-email-vijay.kilari@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1442581755-2668-24-git-send-email-vijay.kilari@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: vijay.kilari@gmail.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com, tim@xen.org, xen-devel@lists.xen.org Cc: Prasun.Kapoor@caviumnetworks.com, Vijaya Kumar K , manish.jaggi@caviumnetworks.com List-Id: xen-devel@lists.xenproject.org On 18/09/15 14:09, vijay.kilari@gmail.com wrote: > diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h > index 6a5c6a0..49630a3 100644 > --- a/xen/include/asm-arm/domain.h > +++ b/xen/include/asm-arm/domain.h > @@ -101,6 +101,9 @@ struct arch_domain > * struct arch_vcpu. > */ > struct pending_irq *pending_irqs; > +#ifdef HAS_GICV3 > + struct pending_irq *pending_lpis; > +#endif It's rather strange to expose nr_lpis, vgic_is_domain_lpi to anyone but not pending_lpis. Please either expose to anyone anything related to LPIs or nothing. But not only some of them for convenience in the code. As for physical LPIs I would much prefer to see this code compiled for everyone. Regards, -- Julien Grall