From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, guangmuzhu@gmail.com
Subject: Re: [Qemu-devel] [PATCH] raw-win32: Fix write request error handling
Date: Thu, 24 Sep 2015 06:55:04 -0600 [thread overview]
Message-ID: <5603F2A8.9010905@redhat.com> (raw)
In-Reply-To: <1443086067-8209-1-git-send-email-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 978 bytes --]
On 09/24/2015 03:14 AM, Kevin Wolf wrote:
> aio_worker() wrote the return code to the wrong variable.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> Tested-by: Guangmu Zhu <guangmuzhu@gmail.com>
> ---
> block/raw-win32.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/block/raw-win32.c b/block/raw-win32.c
> index 68f2338..b562c94 100644
> --- a/block/raw-win32.c
> +++ b/block/raw-win32.c
> @@ -119,9 +119,9 @@ static int aio_worker(void *arg)
> case QEMU_AIO_WRITE:
> count = handle_aiocb_rw(aiocb);
> if (count == aiocb->aio_nbytes) {
> - count = 0;
> + ret = 0;
> } else {
> - count = -EINVAL;
> + ret = -EINVAL;
> }
> break;
> case QEMU_AIO_FLUSH:
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2015-09-24 12:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 9:14 [Qemu-devel] [PATCH] raw-win32: Fix write request error handling Kevin Wolf
2015-09-24 12:55 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5603F2A8.9010905@redhat.com \
--to=eblake@redhat.com \
--cc=guangmuzhu@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.