All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] drbd-utils: bump version to 8.9.4
Date: Thu, 24 Sep 2015 14:07:58 +0100	[thread overview]
Message-ID: <5603F5AE.6040306@imgtec.com> (raw)
In-Reply-To: <20150924150016.5c412aa0@PAL-U515208D001>

Hi Christophe,

On 09/24/2015 02:00 PM, Christophe Vu-Brugier wrote:
> Hi Vicente,
> 
> Thank you for your review!
> 
> On Thu, 24 Sep 2015 11:54:36 +0100, Vicente Olivert Riera wrote :
>> That hash value is wrong:
>>
>> ERROR: drbd-utils-8.9.4.tar.gz has wrong sha256 hash:
>> ERROR: expected:
>> 01a8924f8bc1370fc91e0495989d69b65c3b08346006d614d4b1dbdcd1caade5
>> ERROR: got     :
>> 38929279d1bf549fd1ade4ce6773a6fe209db51bbb0efe7bf6d2b7871ba0afbc
>>
>> Please send an v2 with the right hash value.
> 
> That's very surprising, but you are right. The content of the tarball
> has changed since I last downloaded it (on Monday 21st). It seems a new
> tarball with the same name was released on Tuesday. It contains a set
> of fixes committed two days ago:
> 
>   http://git.drbd.org/gitweb.cgi?p=drbd-utils.git;a=shortlog

Then it wasn't your fault. They should have released a new tarball with
a different name. What they did is not a good practice. Anyway...

> I will respin my patch to fix the checksum and modify the commit
> message for Autobuild as you suggested.

Great! Don't forget to add the right subject prefix "PATCH v2", append
the Changelog below "---" and mark this patch as superseded in Patchwork :-)

http://buildroot.org/downloads/manual/manual.html#submitting-patches

Scroll down until "21.5.2. Patch revision changelog".

Regards,

Vincent.

> Thanks again!
> 

      reply	other threads:[~2015-09-24 13:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-21  8:48 [Buildroot] [PATCH 1/1] drbd-utils: bump version to 8.9.4 Christophe Vu-Brugier
2015-09-24 10:54 ` Vicente Olivert Riera
2015-09-24 13:00   ` Christophe Vu-Brugier
2015-09-24 13:07     ` Vicente Olivert Riera [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5603F5AE.6040306@imgtec.com \
    --to=vincent.riera@imgtec.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.