From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 80591E00A73; Thu, 24 Sep 2015 07:02:46 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail.chez-thomas.org (mail.mlbassoc.com [65.100.170.105]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id CC960E00AB6 for ; Thu, 24 Sep 2015 07:02:39 -0700 (PDT) Received: by mail.chez-thomas.org (Postfix, from userid 1998) id F4118F811DF; Thu, 24 Sep 2015 08:02:38 -0600 (MDT) Received: from [192.168.1.114] (zeus [192.168.1.114]) by mail.chez-thomas.org (Postfix) with ESMTP id 07BE3F811DF; Thu, 24 Sep 2015 08:02:38 -0600 (MDT) To: meta-freescale@yoctoproject.org References: <1443097964-32449-1-git-send-email-otavio@ossystems.com.br> <1443097964-32449-6-git-send-email-otavio@ossystems.com.br> From: Gary Thomas Message-ID: <56040280.8010509@mlbassoc.com> Date: Thu, 24 Sep 2015 08:02:40 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: [meta-fsl-arm PATCH v2 5/5] Move mxs-base.inc contents to imx-base.inc X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Sep 2015 14:02:46 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 2015-09-24 07:59, Otavio Salvador wrote: > On Thu, Sep 24, 2015 at 10:47 AM, Daiane Angolini wrote: >> On Thu, Sep 24, 2015 at 9:32 AM, Otavio Salvador >> wrote: >>> The consolidation of all i.MX related base settings allow for a more >>> global view of the settings in place. Up to now, the i.MX 23 and i.MX >>> 28 SoCs were using the mxs-base.inc file, causing fragmentation. >>> >>> The changes necessary to keep all i.MX 23 and i.MX 28 reference boards >>> working properly has been done, some values need to be reworked to >> >> The consolidation of all i.MX related base settings allows a more >> global view of the settings in place. >> >> One of the causes of this patch is the fragmentation caused by i.MX23 >> and i.MX28 SoCs using mxs-base.inc. >> >> The changes needed to get i.MX23 and i.MX28 SoCs working have been >> included in imx-base.inc file already, ... > > I reworked this as: > > --- > The consolidation of all i.MX related base settings allows a more > global view of the settings in place. > > One of the causes of this patch is the fragmentation caused by i.MX23 One of the reasons for this patch ... > and i.MX28 SoCs using mxs-base.inc. > > The changes needed to get i.MX23 and i.MX28 SoCs working have been > included in imx-base.inc file already and some values required rework > to apply to specific SoC families to avoid regressions. > --- > > Better? > >>> apply to SoC families instead of global setting but the price for >>> clearness seems worth it. >> >> This piece I don't understand. Are additional changes needed for >> future (#FIXME)? Or you are still talking about the motivation of this >> patch? > > No; just explaining there are changes to avoid regressions. I reworked > the commit log. > > ... >>> +UBOOT_MAKE_TARGET_mxs = "u-boot.sb" >>> +UBOOT_MAKE_TARGET_mx51 = "u-boot.imx" >>> +UBOOT_MAKE_TARGET_mx53 = "u-boot.imx" >>> +UBOOT_MAKE_TARGET_mx6 = "u-boot.imx" >>> +UBOOT_MAKE_TARGET_mx6sl = "u-boot.imx" >>> +UBOOT_MAKE_TARGET_mx6sx = "u-boot.imx" >> >> Why are you duplicating for sl and sx? >> >> I don't see imx6ul > > My fault; I will expand it. > >>> +UBOOT_MAKE_TARGET_mx7 = "u-boot.imx" >>> +UBOOT_MAKE_TARGET_vf = "u-boot.imx" >>> + >>> +UBOOT_SUFFIX_mxs = "sb" >>> +UBOOT_SUFFIX_mx51 = "imx" >>> +UBOOT_SUFFIX_mx53 = "imx" >>> +UBOOT_SUFFIX_mx6 = "imx" >>> +UBOOT_SUFFIX_mx6sl = "imx" >>> +UBOOT_SUFFIX_mx6sx = "imx" >> >> Why are you duplicating for sl and sx? >> >> I don't see imx6ul > > Ditto. > >>> +UBOOT_SUFFIX_mx7 = "imx" >>> +UBOOT_SUFFIX_vf = "imx" >>> + >>> +UBOOT_ENTRYPOINT_mxs = "0x40008000" >>> UBOOT_ENTRYPOINT_mx51 = "0x90008000" >>> UBOOT_ENTRYPOINT_mx53 = "0x70008000" >>> UBOOT_ENTRYPOINT_mx6 = "0x10008000" >>> @@ -132,6 +149,7 @@ PREFERRED_PROVIDER_virtual/libg2d_mx6ul = "" >>> >>> # Handle default kernel >>> IMX_DEFAULT_KERNEL = "linux-imx" >>> +IMX_DEFAULT_KERNEL_mxs = "linux-fslc" >>> IMX_DEFAULT_KERNEL_mx5 = "linux-fslc" >>> IMX_DEFAULT_KERNEL_mx6 = "linux-fslc-mx6" >>> IMX_DEFAULT_KERNEL_mx6ul = "linux-imx" >>> @@ -140,8 +158,16 @@ PREFERRED_PROVIDER_virtual/kernel ??= "${IMX_DEFAULT_KERNEL}" >>> >>> SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext4" >>> IMAGE_FSTYPES ?= "ext4 sdcard.gz" >>> - >>> -SERIAL_CONSOLE = "115200 ttymxc0" >>> +IMAGE_FSTYPES_mxs ?= "ext4 uboot.mxsboot-sdcard sdcard.gz" >>> + >>> +SERIAL_CONSOLE_mxs = "115200 ttyAMA0" >>> +SERIAL_CONSOLE_mx51 = "115200 ttymxc0" >>> +SERIAL_CONSOLE_mx53 = "115200 ttymxc0" >>> +SERIAL_CONSOLE_mx6 = "115200 ttymxc0" >>> +SERIAL_CONSOLE_mx6sl = "115200 ttymxc0" >>> +SERIAL_CONSOLE_mx6sx = "115200 ttymxc0" >>> +SERIAL_CONSOLE_mx7 = "115200 ttymxc0" >>> +SERIAL_CONSOLE_vf = "115200 ttymxc0" >> >> Can you, please, explain why we cannot have SERIAL_CONSOLE any more >> and only override for mxs? > > I will rework this. > -- ------------------------------------------------------------ Gary Thomas | Consulting for the MLB Associates | Embedded world ------------------------------------------------------------