All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] graphite2: new package
Date: Thu, 24 Sep 2015 15:56:39 +0100	[thread overview]
Message-ID: <56040F27.4060505@imgtec.com> (raw)
In-Reply-To: <1443105369-30869-1-git-send-email-gustavo.zacarias@free-electrons.com>

Dear Gustavo Zacarias,

On 09/24/2015 03:36 PM, gustavo.zacarias at free-electrons.com wrote:
> From: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
> 
> Signed-off-by: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
Reviewed-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Tested-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

Build test for MIPS architecture:

$ file output/target/usr/lib/libgraphite2.so.3.0.1
output/target/usr/lib/libgraphite2.so.3.0.1: ELF 64-bit LSB shared
object, MIPS, MIPS64 rel2 version 1 (SYSV), dynamically linked, with
unknown capability 0x756e670000000f41 = 0x104000000070100, stripped

One nit-pick comment below; please scroll down.

[snip]

> diff --git a/package/graphite2/Config.in b/package/graphite2/Config.in
> new file mode 100644
> index 0000000..4db0835
> --- /dev/null
> +++ b/package/graphite2/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_GRAPHITE2
> +	bool "graphite2"
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on !BR2_STATIC_LIBS
> +	help
> +	  Graphite is a project within SIL's scripts and software dev
> +	  groups to provide cross-platform rendering for complex
> +	  writing systems.

You could have the same in only two lines if you wrap them to 72 characters.

Regards,

Vincent.

[snip]

  reply	other threads:[~2015-09-24 14:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-24 14:36 [Buildroot] [PATCH] graphite2: new package gustavo.zacarias at free-electrons.com
2015-09-24 14:56 ` Vicente Olivert Riera [this message]
2015-09-27 21:18 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56040F27.4060505@imgtec.com \
    --to=vincent.riera@imgtec.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.