From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 3/5] drm: omapdrm: tiler: Fix module autoload for OF platform driver Date: Thu, 24 Sep 2015 18:43:33 +0300 Message-ID: <56041A25.60400@ti.com> References: <20150917142146.GA20176@goodgumbo.baconseed.org> <5603D374.3010806@ti.com> <20150924153620.GA28419@goodgumbo.baconseed.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0076862320==" Return-path: Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) by gabe.freedesktop.org (Postfix) with ESMTPS id C5B1D7215E for ; Thu, 24 Sep 2015 08:43:43 -0700 (PDT) In-Reply-To: <20150924153620.GA28419@goodgumbo.baconseed.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Luis de Bethencourt Cc: Grygorii Strashko , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Javier Martinez Canillas , Laurent Pinchart List-Id: dri-devel@lists.freedesktop.org --===============0076862320== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QkBOPRBqBfI0r322GXKnSDSGTrCSAGiF8" --QkBOPRBqBfI0r322GXKnSDSGTrCSAGiF8 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 24/09/15 18:36, Luis de Bethencourt wrote: > I am a bit confused. Yes, it's an interesting mess due to legacy reasons. Maybe we manage to fix it some day... > So how the OMAP DRM auto loading is supposed to work when using Device = Trees? omapdrm isn't a real HW device driver at the moment. There's another driver, omapdss, which is the HW driver, and omapdrm uses omapdss. omapdrm platform device is created by omap platform code at boot time, the same way for both DT and non-DT boots. > As far as I can tell, the main omap drm driver does not have a OF devic= e ID > table and a .of_match it only has a MODULE_ALIAS("platform:" DRIVER_NAM= E), > but the tiler driver (that is built-in the omap drm driver) does have a= a > OF device ID table and I see in DTS that are device nodes using those c= ompatible > strings >=20 > $ git grep omap4-dmm arch/arm/boot/dts/omap* > arch/arm/boot/dts/omap4.dtsi: compatible =3D "ti,omap= 4-dmm"; >=20 > Does that mean there is no need for MODULE_ALIAS("platform:" DMM_DRIVER= _NAME)? No, I think that's the thing that makes omapdrm load. Tomi --QkBOPRBqBfI0r322GXKnSDSGTrCSAGiF8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWBBolAAoJEPo9qoy8lh71LKgP/jR72qhkjlv/svbedtjFXTOs gPHuBiX0780vgl0nlNXARjA3/uv1PGa5/kFJ9vN5mQ4OzdPLB3nm5Irb1tPorZqF oSunkpLr7T/OsDUOG3fLPJJ6WCSY9H1yLz8sIHq4fqQy4mbkkXjZo9MyCMiXqKyJ WEbHF+yPxdqajOd/jJk6yP0NqRFSYTVdcjUKsBSMXVOrjfRhUKDlwIDNArD7QaG1 k50KAmxU3M37AZI2w1TdWZvt0Dl9Gx/1Tq/cJ0umH6fLFcYdNnCeRbkoXDH/a+KJ jSW4BSZeIEjvoJuDKuFif721eAHpy4ltf/JcpytkOi1a+s9thB9YOz2QJaiz2Ld2 5LdQcADh1pqiZloyFwanaI7y/Lt9frDx6BGLtjE8F4JbeQIgxab33iwE6FQjvKmb YWo6flJOyu9IHxlavgIkb2o2bPcHmtLPDXCKXjzDd8bi4CVd/apfl3WImiqJ1DD2 7rX3TabdoOTqrPI6viytHzncJrXvW5AqZO0KD0HP4oh+BXMOOMnRxGnw/K78u7An /VUoKr+LusXbE6UF17Bj9EvS/zNONoaKfzsDz7rynruVkyoE9L3kzvXCnXfuYWII e7w5RBSCwfiz5Eo4Ze5X30Y6O8mg2TCRm7NG97MCJxuiKjBMSL88BX7/ngMKWTtd AQbNOFObmyB2GH4vuL9i =D4LT -----END PGP SIGNATURE----- --QkBOPRBqBfI0r322GXKnSDSGTrCSAGiF8-- --===============0076862320== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0076862320==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756226AbbIXPnq (ORCPT ); Thu, 24 Sep 2015 11:43:46 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:36020 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753102AbbIXPnp (ORCPT ); Thu, 24 Sep 2015 11:43:45 -0400 Subject: Re: [PATCH 3/5] drm: omapdrm: tiler: Fix module autoload for OF platform driver To: Luis de Bethencourt References: <20150917142146.GA20176@goodgumbo.baconseed.org> <5603D374.3010806@ti.com> <20150924153620.GA28419@goodgumbo.baconseed.org> CC: , David Airlie , Laurent Pinchart , Grygorii Strashko , Rob Clark , , Javier Martinez Canillas From: Tomi Valkeinen Message-ID: <56041A25.60400@ti.com> Date: Thu, 24 Sep 2015 18:43:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150924153620.GA28419@goodgumbo.baconseed.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QkBOPRBqBfI0r322GXKnSDSGTrCSAGiF8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --QkBOPRBqBfI0r322GXKnSDSGTrCSAGiF8 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 24/09/15 18:36, Luis de Bethencourt wrote: > I am a bit confused. Yes, it's an interesting mess due to legacy reasons. Maybe we manage to fix it some day... > So how the OMAP DRM auto loading is supposed to work when using Device = Trees? omapdrm isn't a real HW device driver at the moment. There's another driver, omapdss, which is the HW driver, and omapdrm uses omapdss. omapdrm platform device is created by omap platform code at boot time, the same way for both DT and non-DT boots. > As far as I can tell, the main omap drm driver does not have a OF devic= e ID > table and a .of_match it only has a MODULE_ALIAS("platform:" DRIVER_NAM= E), > but the tiler driver (that is built-in the omap drm driver) does have a= a > OF device ID table and I see in DTS that are device nodes using those c= ompatible > strings >=20 > $ git grep omap4-dmm arch/arm/boot/dts/omap* > arch/arm/boot/dts/omap4.dtsi: compatible =3D "ti,omap= 4-dmm"; >=20 > Does that mean there is no need for MODULE_ALIAS("platform:" DMM_DRIVER= _NAME)? No, I think that's the thing that makes omapdrm load. Tomi --QkBOPRBqBfI0r322GXKnSDSGTrCSAGiF8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWBBolAAoJEPo9qoy8lh71LKgP/jR72qhkjlv/svbedtjFXTOs gPHuBiX0780vgl0nlNXARjA3/uv1PGa5/kFJ9vN5mQ4OzdPLB3nm5Irb1tPorZqF oSunkpLr7T/OsDUOG3fLPJJ6WCSY9H1yLz8sIHq4fqQy4mbkkXjZo9MyCMiXqKyJ WEbHF+yPxdqajOd/jJk6yP0NqRFSYTVdcjUKsBSMXVOrjfRhUKDlwIDNArD7QaG1 k50KAmxU3M37AZI2w1TdWZvt0Dl9Gx/1Tq/cJ0umH6fLFcYdNnCeRbkoXDH/a+KJ jSW4BSZeIEjvoJuDKuFif721eAHpy4ltf/JcpytkOi1a+s9thB9YOz2QJaiz2Ld2 5LdQcADh1pqiZloyFwanaI7y/Lt9frDx6BGLtjE8F4JbeQIgxab33iwE6FQjvKmb YWo6flJOyu9IHxlavgIkb2o2bPcHmtLPDXCKXjzDd8bi4CVd/apfl3WImiqJ1DD2 7rX3TabdoOTqrPI6viytHzncJrXvW5AqZO0KD0HP4oh+BXMOOMnRxGnw/K78u7An /VUoKr+LusXbE6UF17Bj9EvS/zNONoaKfzsDz7rynruVkyoE9L3kzvXCnXfuYWII e7w5RBSCwfiz5Eo4Ze5X30Y6O8mg2TCRm7NG97MCJxuiKjBMSL88BX7/ngMKWTtd AQbNOFObmyB2GH4vuL9i =D4LT -----END PGP SIGNATURE----- --QkBOPRBqBfI0r322GXKnSDSGTrCSAGiF8--