From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757239AbbIXRgK (ORCPT ); Thu, 24 Sep 2015 13:36:10 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:16594 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757225AbbIXRgE (ORCPT ); Thu, 24 Sep 2015 13:36:04 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-77-5604347f11fa Subject: Re: [PATCH v2] usb: gadget: f_sourcesink: fix function params handling To: balbi@ti.com, Robert Baldyga References: <1443108189-3464-1-git-send-email-r.baldyga@samsung.com> <20150924164913.GE14151@saruman.tx.rr.com> Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, andrzej.p@samsung.com, b.zolnierkie@samsung.com, stable@vger.kernel.org From: Krzysztof Opasiak Message-id: <5604347E.1090107@samsung.com> Date: Thu, 24 Sep 2015 19:35:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <20150924164913.GE14151@saruman.tx.rr.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrFLMWRmVeSWpSXmKPExsVy+t/xy7r1JixhBheXWVjMetnOYrFxxnpW i4P36y2aF69ns7i8aw6bxaJlrcwWDw7vZLdYsPERowOHx/65a9g9+rasYvQ4fmM7k8fnTXIB LFFcNimpOZllqUX6dglcGZvWXGUpeMFWsa+9gbmB8SRrFyMnh4SAicSuE5+ZIGwxiQv31rN1 MXJxCAksZZT4f2kdI4TznFHi1IF7bCBVwgL+Ev3TL7GA2CICFhJbprSD2UIChRJznyxhAWlg FljCKHF2/gcgh4ODTUBfYt4uUZAaXgEtidWrmplBbBYBVYlzt9+D9YoKREicOvuWDaJGUOLH 5HtgrZwC5hLL/2mBhJkFbCUWvF/HAmHLS2xe85Z5AqPALCQds5CUzUJStoCReRWjaGppckFx UnquoV5xYm5xaV66XnJ+7iZGSIh/2cG4+JjVIUYBDkYlHl4HLeYwIdbEsuLK3EOMEhzMSiK8 B0RYwoR4UxIrq1KL8uOLSnNSiw8xSnOwKInzzt31PkRIID2xJDU7NbUgtQgmy8TBKdXAGC+m 9870ILfCuoq7Yn2fOz7eNbN7pO2R/MRv2f2vx/dW9ucF2t5k7kjvUtmVa+S/U+IwY7njfu97 B0xz1vsf1nq+cs+T99seWohME3xwhl36zYfL0trnD0vvlnLMffmNk/mdgkKGmvLDeasnfnix qiakp7aR3/ic967PjMUNXcuuy4XwM/syKLEUZyQaajEXFScCACX+98ZtAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/24/2015 06:49 PM, Felipe Balbi wrote: > On Thu, Sep 24, 2015 at 05:23:09PM +0200, Robert Baldyga wrote: >> Move function parameters to struct f_sourcesink to make them per instance >> instead of having them as global variables. Since we can have multiple >> instances of USB function we also want to have separate set of parameters >> for each instance. >> >> Cc: # 3.10+ >> Signed-off-by: Robert Baldyga > > why do you think this is stable material ? Looks like it's not > fixing anything to me; just implementing a brand new requirement. > Please see my answer in loopback patch[1]. It's totally the same case. Both those functions have the same bug. Footnotes: 1 - http://marc.info/?l=linux-usb&m=144311466118170&w=2 -- Krzysztof Opasiak Samsung R&D Institute Poland Samsung Electronics