From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfC2B-0007yT-59 for qemu-devel@nongnu.org; Thu, 24 Sep 2015 15:18:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfC26-00042o-1j for qemu-devel@nongnu.org; Thu, 24 Sep 2015 15:18:22 -0400 Received: from v220110690675601.yourvserver.net ([37.221.199.173]:53178) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfC25-00042H-SB for qemu-devel@nongnu.org; Thu, 24 Sep 2015 15:18:17 -0400 Message-ID: <56044C76.9060606@weilnetz.de> Date: Thu, 24 Sep 2015 21:18:14 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1442931206-869-1-git-send-email-berrange@redhat.com> <560194B4.7060201@weilnetz.de> <20150923083324.GJ15421@redhat.com> In-Reply-To: <20150923083324.GJ15421@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 REPOST] oslib-win32: only provide localtime_r/gmtime_r if missing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Kevin Wolf , Peter Maydell , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Stefan Hajnoczi , Igor Mammedov , "Denis V. Lunev" Am 23.09.2015 um 10:33 schrieb Daniel P. Berrange: > On Tue, Sep 22, 2015 at 07:49:40PM +0200, Stefan Weil wrote: >> Hi, >> >> I suggest cleaning some comments, mostly using the "official" >> spellings for MinGW and Mingw-w64. [...] >> Otherwise this patch looks good. >> >> If you agree, I'd clean the comments before I add >> the patch to my patch queue for Windows >> (git://qemu.weilnetz.de/qemu.git wxx). > > Yes, I'm fine with you applying it to your queue and adding the fixes > mentioned. > > Regards, > Daniel Thanks. Your patch with the fixes is now applied to git://qemu.weilnetz.de/qemu.git wxx. Stefan