From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Daney Subject: Re: [PATCH] net: mdio-octeon: Add PCI driver binding. Date: Thu, 24 Sep 2015 15:54:30 -0700 Message-ID: <56047F26.9070305@caviumnetworks.com> References: <56047367.3060101@caviumnetworks.com> <20150924.151451.1059470233561232912.davem@davemloft.net> <56047D15.9080105@caviumnetworks.com> <20150924.155004.109163182451628208.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150924.155004.109163182451628208.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org To: David Miller Cc: ddaney.cavm@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org, f.fainelli@gmail.com, netdev@vger.kernel.org, david.daney@cavium.com List-Id: devicetree@vger.kernel.org On 09/24/2015 03:50 PM, David Miller wrote: > From: David Daney > Date: Thu, 24 Sep 2015 15:45:41 -0700 > >> 2) The OF device tree nodes for PCI devices do not result in the >> creation of a platform device. > > But they are created for the children right? And that's the one > you need them for probing. > > I'm still not convinced, sorry. > Let's let this topic rest for a few days. My original patch was defective, so it cannot be merged. I will sleep on this, try a few things and perhaps revisit it if I still think it is advisable. Thanks, David Daney From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932207AbbIXWyk (ORCPT ); Thu, 24 Sep 2015 18:54:40 -0400 Received: from mail-bn1on0054.outbound.protection.outlook.com ([157.56.110.54]:21741 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753227AbbIXWyh (ORCPT ); Thu, 24 Sep 2015 18:54:37 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Daney@caviumnetworks.com; Message-ID: <56047F26.9070305@caviumnetworks.com> Date: Thu, 24 Sep 2015 15:54:30 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: David Miller CC: , , , , , , , , , , Subject: Re: [PATCH] net: mdio-octeon: Add PCI driver binding. References: <56047367.3060101@caviumnetworks.com> <20150924.151451.1059470233561232912.davem@davemloft.net> <56047D15.9080105@caviumnetworks.com> <20150924.155004.109163182451628208.davem@davemloft.net> In-Reply-To: <20150924.155004.109163182451628208.davem@davemloft.net> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.2.3.194] X-ClientProxiedBy: BLUPR07CA0043.namprd07.prod.outlook.com (10.255.223.156) To BLUPR0701MB1715.namprd07.prod.outlook.com (25.163.85.141) X-Microsoft-Exchange-Diagnostics: 1;BLUPR0701MB1715;2:lq8c+odIR7fCkAJc6xGHfvfWn5QZjB3xNEwgQJSTFKqCmkLY9wb6/M6zWaZYgSm+lwYjSl7bwgC7iU1y3/WRpmwbaNa2tTdSY/BahKad9PIa91Qxp2aRVCa0wBmz8G8jwfH8kJ1rjq4CXvPwwA+EII18e5m81CU/k9DUbreGtaQ=;3:QjfrxxzhmPg/s8pGdCc9cb6fhIkkNJEcPKuiSG7/PYEV2M7qSvrepHL31hmuTPZpeMKMzIZ74eOwL2V3wwmKJxmkgD0N3F9QfqE4AM0BFh/wUiruaLtgZlBqpQhdCrxK0qXbYMi89EMpgEqboFc02A==;25:DCnKRjZr36TknvN6omIwOYAcX2I4a5dNPyYd1ysLWE5t0+1tTYJkIA3iK1+NQpskc0B4F3m/EBzItXLd1aBqwc/LZGN3qHIRH0U/GjO97rjA3tkWrL0D0UMiXfDZIYZhXrFZiFzF3H3IPw9bOBVXPEf2coNmaMMpzLKvrwCv9owTOHKDPAuZSdKH2A24F4jnrHcpY2ETQIelPbIWz7lWCKExfvrpuQHlUfkcWHxKWgs717W2NgSU3GGNgJwg8uws X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1715; X-Microsoft-Exchange-Diagnostics: 1;BLUPR0701MB1715;20:KvBmwU7WaWKC0zdrOp/suVM9Qqumb7PWibFtBIeMfJcOOICMuuh1sHImHKbJ0ly3jFx6iif6nm8AOoQ447IbbGCGdSa2YgZaf4rEAGo3KbXXnd7vObCj95xDsa6o1wd+nQZBhBVRUs5mq7xAIS7gfBeScHIpg1GX7fOG2/nhGij1d4/ePRC2pVeNsu7gLmiBQkmdBWs0ihSiA9xpTVbsLhoc4Zkadu4Vk1WEelzxx/IsQJGZ/IcBVOMK2Ds4kTGOSsgfrcukQB/PG3mymyOTwhFrXa+9cf+orBUn4pL38MA8Iq8fUa7n7+j2GpdeTGLHVwS5MehAaFDJJYkwW1i0apM7fzR2FAlou2iLRDWdVrwDTBPM8sw6uYy30a4siRuqL9g4PQ6XmnPV9894CLs35jBRl8s+sa/n04631QR/0RMvtqs8kwcoVzdpe6/sCmeSh5FeScBcXm3hUwOazHamGRPJlTSUnLgHrj6s4NS25itJP7rY2vwQuzCwXZBUNpUELu/SSQHh8m7DeseJfBDSkh16m9nIQmAjdSZTu0okUS1XDaYt6akEXV2Id6tehq4a6XpfEoRbzJ/CVt3B3KIY0AM8lG927hRC1GMpL3P0kss= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001);SRVR:BLUPR0701MB1715;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1715; X-Microsoft-Exchange-Diagnostics: 1;BLUPR0701MB1715;4:owFGjcqxFIiH6ZFtQsX32u9CchSn816AleniADPjX2TRtUklGJLIW8fFlrAvw46nxghKnfM37OjHAaklLfRImsswGOPh9VnbdIj/vCs/5SCS4DDbu8s9QSPIo1jzNTTU0Pz92coO7lbJ0DMmiI3oME4Plau41C7WIH5Ju5MU82Jth34fTKfzYRCNypcnUhkiB9/6YoTrrt5begHR5TR/09GXlTmu1JLjSGQBCNhmg18ALmRNDYWP0/mjJywYo7u6XzbaWtTn3nWgrX9INPt77N+yU/hg5JGTcWY1yaQVpkELSwSwh57fGlebdacsrozQHqtXOu0US88A5cgn7g1u84OP0WWdQqHISDdZJ7BKhWU= X-Forefront-PRVS: 070912876F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(189002)(377454003)(479174004)(164054003)(24454002)(199003)(189998001)(105586002)(110136002)(83506001)(5001960100002)(99136001)(106356001)(33656002)(68736005)(65816999)(76176999)(50986999)(54356999)(62966003)(101416001)(87266999)(77096005)(50466002)(46102003)(77156002)(5004730100002)(19580405001)(36756003)(5007970100001)(2950100001)(87976001)(93886004)(19580395003)(40100003)(69596002)(4001540100001)(122386002)(97736004)(5001830100001)(5001860100001)(23756003)(64126003)(4001350100001)(92566002)(81156007)(59896002)(80316001)(66066001)(53416004)(47776003)(65806001)(42186005)(65956001)(64706001);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR0701MB1715;H:dl.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;BLUPR0701MB1715;23:GQ+UG99HQBjRid0VV/jNpieNvp6KBCOP8/RpD?= =?iso-8859-1?Q?WYKA0hHpQElIfyQuAGQ+2MRP1IzkUmF7tUm5SjbgrZUbeSyo0CuYJLxv2e?= =?iso-8859-1?Q?SBFV0SivOi4f7cpeMLahGjdV1LxP4C1Vgl8kJuyXSud41gtSUifIf31Npb?= =?iso-8859-1?Q?gsz7NENQD37+Lvq0pky9UbaamhlQThw2ixYFNWI49AbL++SB2Pk6E5bo7J?= =?iso-8859-1?Q?eg1kkEr6Dr3UoAf5gnQ64YmS/5pAgs93eufPzwyjZzfeB2KbBtrdEwaD9I?= =?iso-8859-1?Q?mCi5BWrSRA7Qzgs9q1zfl9i72fSBv3kKbNpkMFOn7dx/olt7rxI4+XwDLo?= =?iso-8859-1?Q?q3EPxjEJNV1YHHaa2D0goI0FBFejqRZZa4tWATvMnlkibmA92EoLsimQHP?= =?iso-8859-1?Q?YhioXIyoJFybf0av2F8ZGFbmubC6il3p+1I+FppHQw6AQrkBLRwsUDakan?= =?iso-8859-1?Q?WIoDdfawvJ/iSCcH9WXo3vM41yjWseW74Toyf++s73n7vibSplaKoABqwO?= =?iso-8859-1?Q?WimvyhCLP4BLli+rAM+nuIDIbt73hlaqfB9vpjt7YEEg5UZtJZoapYNQEl?= =?iso-8859-1?Q?+MjEJUTFUtBsGdBQFWMqMWZEFVd0fxbWRtSwJC5gVYgAIU24f1hCmPDrl9?= =?iso-8859-1?Q?jPf5eZ3wmnVWkArz3kJ4HxVNvMYKalY9obFz5QHb2IjgpaPvlQooF75GtW?= =?iso-8859-1?Q?DCRwy4Lkd6wDuEbeQFB6GsMWKBSsmskm5QyMjYGnObP3GY8H9kez+rkIvg?= =?iso-8859-1?Q?tUh+A+Cd5Ufc6nfyWkqzP2tx7LUQkbQKdDiQofuywI1kbljlAMtW5EhO38?= =?iso-8859-1?Q?YSMXgysjAMhdxYh0/kqwQsnx7Wx9aFZSR0IRX1m9HcwCJ6UfWWdgzTn8/M?= =?iso-8859-1?Q?Dz1TsDl0BoRh1C2kVnnvMRprXegW2/th4Wui0B+eihftr/AV2SWn7wuIE/?= =?iso-8859-1?Q?079P5WoGAavEAUy4DFHd673xRzlEMFemrlN07DZa+K4KHukvK6k1QlQrGW?= =?iso-8859-1?Q?OVI5m6Gq9hFewC/GhmKf2SWTHUqYKTm63JqId6et1zdLOEDTMiXKMEyLJp?= =?iso-8859-1?Q?m5iIrEwIHhi7286D1KHPYqXH15QL+xLgN8QWtD0IHEV20tqcrJk5dFGXv1?= =?iso-8859-1?Q?91/IM2pt4wuc73vLx8JqrmvhHn+EGG6BKbo/aFO6bz6fGA5qltvSk3Ce9Q?= =?iso-8859-1?Q?gvn4F+1FAmJKmF42K4S0cqrhTKEha4iqRq0E9azyHOJ67Cc5E0Sro2wGOl?= =?iso-8859-1?Q?TpYH7yQJJ1NLRln+VGVrfGWA4O3p/6PetibzNOavo2OcaDu6lCiLGSGzYk?= =?iso-8859-1?Q?RaF29jKl5kD+SG89NV7rZ5+toowMuGJDxUlOz//uhQKfXITp4cHdEPuUqT?= =?iso-8859-1?Q?+B9Y6kJvsdm2EygSzar6JDaUEuEZLqxjKTynIvGoTYnQuPlE57PmboSJTI?= =?iso-8859-1?Q?jbJi/ytrKgxTUOxLWg40O8SAioabdVMYEaamprAyA72kSJwG4KpGfUjBNX?= =?iso-8859-1?Q?ScB+L3yfxADKbFQvsERDjFsFopcfMVs3ghRHqtCTnJg?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR0701MB1715;5:qA14EBnKy2minVo7o51yuD+V1pDPXY4f1MayJyMa0t0VF8WsB8p3pwW4bq7Cet9MCepmPuVwCw736memexErWmB25paYWfr2MQonjUZhCKJWAwPdIAwO9mX/ncE6Fcvsh0gMsIoLaFZEHnem/IgPsg==;24:Miw9gK1mw6R1YZVLshLWCpkwW3j6GVeklmIsCxjzdGfzxaLGmYOhwbWnAhsx1X7xZ8nboaqn/GW89wSC24lOC8QjZJMCa/0D5891yV2m9N8=;20:QoND2/ZR8bzAZp/qyv0R8jJx5RxxazkUITrzQ6KMOobz1axLfnB+TuHunp5f7fpQNJwd/jhfRu8gKAlK03TLxQ== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2015 22:54:33.2750 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1715 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/24/2015 03:50 PM, David Miller wrote: > From: David Daney > Date: Thu, 24 Sep 2015 15:45:41 -0700 > >> 2) The OF device tree nodes for PCI devices do not result in the >> creation of a platform device. > > But they are created for the children right? And that's the one > you need them for probing. > > I'm still not convinced, sorry. > Let's let this topic rest for a few days. My original patch was defective, so it cannot be merged. I will sleep on this, try a few things and perhaps revisit it if I still think it is advisable. Thanks, David Daney