From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37166) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfLub-0007DQ-JJ for qemu-devel@nongnu.org; Fri, 25 Sep 2015 01:51:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfLuY-00072d-Cg for qemu-devel@nongnu.org; Fri, 25 Sep 2015 01:51:13 -0400 Received: from mga02.intel.com ([134.134.136.20]:23115) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfLuX-00072M-Mz for qemu-devel@nongnu.org; Fri, 25 Sep 2015 01:51:10 -0400 References: <1442565017-31725-1-git-send-email-tiejun.chen@intel.com> From: "Chen, Tiejun" Message-ID: <5604E0C9.5020109@intel.com> Date: Fri, 25 Sep 2015 13:51:05 +0800 MIME-Version: 1.0 In-Reply-To: <1442565017-31725-1-git-send-email-tiejun.chen@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [v4][PATCH 0/2] libxl: try to support IGD passthrough for qemu upstream List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: ian.campbell@citrix.com, wei.liu2@citrix.com, stefano.stabellini@citrix.com, Ian.Jackson@eu.citrix.com Cc: qemu-devel@nongnu.org, xen-devel@lists.xen.org Ping... Thanks Tiejun On 9/18/2015 4:30 PM, Tiejun Chen wrote: > Ian, > > As we discussed previously, > > http://patchwork.ozlabs.org/patch/457055/ > > now it's time to push this into on xen/tools side since all qemu stuffs > have been merged. > > https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg02094.html > > v4: > > Ian, > > Actually we had v3.5 online previously, which was reviewed by you. > > http://permalink.gmane.org/gmane.comp.emulators.qemu/329100 > > So here I just bring a little bit to refine code just for patch #2 > according to out last conversation. > > v3: > > * Refine some codes based on Campbell's feedback so thanks for Campbell's > kind guideline to patch #2 > * Update the manpages in patch #2 > > v2: > > * Refine patch #2's head description > * Improve codes quality inside patch #1 based on Wei's comments > * Refill the summary inside patch #0 based on Konrad and Wei's suggestion > > When we're working to support IGD GFX passthrough with qemu > upstream, instead of "-gfx_passthru" we'd like to make that > a machine option, "-machine xxx,igd-passthru=on". > > https://lists.nongnu.org/archive/html/qemu-devel/2015-01/msg02050.html > > This need to bring a change on tool side. > > After a discussion with Campbell, we'd like to construct a table to record > all IGD devices we can support. If we hit that table, we should pass that > option. And so we also introduce a new field of type, 'gfx_passthru_kind', > to cooperate with 'gfx_passthru' to cover all scenarios like this, > > gfx_passthru = 0 => sets build_info.u.gfx_passthru to false > gfx_passthru = 1 => sets build_info.u.gfx_passthru to true and > build_info.u.gfx_passthru_kind to DEFAULT > gfx_passthru = "igd" => sets build_info.u.gfx_passthru to false > and build_info.u.gfx_passthru_kind to IGD > > And note actually that option "-gfx_passthru" is just introduced to > work for qemu-xen-traditional so we should get this away from > libxl__build_device_model_args_new() in the case of qemu upstream. > > ---------------------------------------------------------------- > Tiejun Chen (2): > libxl: introduce libxl__is_igd_vga_passthru > libxl: introduce gfx_passthru_kind > > docs/man/xl.cfg.pod.5 | 35 ++++++++-- > tools/libxl/libxl.h | 6 ++ > tools/libxl/libxl_dm.c | 46 +++++++++++-- > tools/libxl/libxl_internal.h | 2 + > tools/libxl/libxl_pci.c | 124 +++++++++++++++++++++++++++++++++++ > tools/libxl/libxl_types.idl | 6 ++ > tools/libxl/xl_cmdimpl.c | 14 +++- > 7 files changed, 223 insertions(+), 10 deletions(-) > > Thanks > Tiejun > >