From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59739) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfNyW-0005ox-PT for qemu-devel@nongnu.org; Fri, 25 Sep 2015 04:03:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfNyK-0000vI-36 for qemu-devel@nongnu.org; Fri, 25 Sep 2015 04:03:24 -0400 Received: from [59.151.112.132] (port=35075 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfNyJ-0000tc-IK for qemu-devel@nongnu.org; Fri, 25 Sep 2015 04:03:11 -0400 Message-ID: <5604FFBB.5080701@cn.fujitsu.com> Date: Fri, 25 Sep 2015 16:03:07 +0800 From: Yang Hongyang MIME-Version: 1.0 References: <1442405768-23019-1-git-send-email-yanghy@cn.fujitsu.com> <1442405768-23019-10-git-send-email-yanghy@cn.fujitsu.com> <87si64qiyr.fsf@blackfin.pond.sub.org> In-Reply-To: <87si64qiyr.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v11 09/12] netfilter: add a netbuffer filter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: thuth@redhat.com, zhang.zhanghailiang@huawei.com, lizhijian@cn.fujitsu.com, jasowang@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On 09/24/2015 05:12 PM, Markus Armbruster wrote: > Yang Hongyang writes: [...] >> diff --git a/vl.c b/vl.c >> index ec589e2..3cf89d5 100644 >> --- a/vl.c >> +++ b/vl.c >> @@ -2794,7 +2794,12 @@ static bool object_create_initial(const char *type) >> if (g_str_equal(type, "rng-egd")) { >> return false; >> } >> - /* TODO: return false for concrete netfilters */ >> + >> + /* return false for concrete netfilters */ > > I find this comment useless, please drop it :) This might be useful for reminding others who wants to implement other filters. > >> + if (g_str_equal(type, "filter-buffer")) { >> + return false; >> + } >> + >> return true; >> } > . > -- Thanks, Yang.