From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cn.fujitsu.com ([59.151.112.132]:9886 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1755057AbbIYIeX (ORCPT ); Fri, 25 Sep 2015 04:34:23 -0400 Subject: Re: [PATCH 3/5] btrfs: Do per-chunk degraded check for remount To: Anand Jain , References: <1442801443-5132-1-git-send-email-quwenruo@cn.fujitsu.com> <1442801443-5132-4-git-send-email-quwenruo@cn.fujitsu.com> <5604EF8B.5060503@oracle.com> <560500F8.9070105@cn.fujitsu.com> <56050619.7060401@oracle.com> From: Qu Wenruo Message-ID: <5605070B.8070705@cn.fujitsu.com> Date: Fri, 25 Sep 2015 16:34:19 +0800 MIME-Version: 1.0 In-Reply-To: <56050619.7060401@oracle.com> Content-Type: text/plain; charset="utf-8"; format=flowed Sender: linux-btrfs-owner@vger.kernel.org List-ID: Thanks Anand, I'm OK with both new patches. Thanks for the modification. Qu Anand Jain wrote on 2015/09/25 16:30 +0800: > Qu, > > Strictly speaking IMO it should be reported to the user on the cli > terminal, and no logging in required. since its not that easy to get > that at this point, I am ok with logging it as error. Since we are > failing the task(mount), error is better. > > I have made that change this on top of the patch > > [PATCH 1/1] Btrfs: consolidate btrfs_error() to btrfs_std_error() > > and sent them both. > > Thanks, Anand > > >> Thanks for pointing this out. >> >> I was quite unsure about using btrfs_info/warn/error. >> >> In this case, I just wan't to output a dmesg info to let user know >> exactly what caused the mount failed. >> Original code output nothing but "failed to open chunk tree", which is >> quite confusing for end user. >> >> I was planning to use btrfs_info, but at least this is really an error >> message, but only to info user the real cause. >> >> Maybe btrfs_warn will be a better choice? >> >> Thanks, >> Qu > >