From: Paolo Bonzini <pbonzini@redhat.com>
To: Bart Van Assche <bart.vanassche@sandisk.com>,
linux-kernel@vger.kernel.org
Cc: James Bottomley <jbottomley@parallels.com>,
Christoph Hellwig <hch@lst.de>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2 4/4] scsi: provide UAPI version of scsi/sg.h and scsi/scsi_ioctl.h
Date: Fri, 25 Sep 2015 10:44:56 +0200 [thread overview]
Message-ID: <56050988.5000504@redhat.com> (raw)
In-Reply-To: <55FADCFF.5000104@sandisk.com>
On 17/09/2015 17:32, Bart Van Assche wrote:
>
>> +
>> +#ifndef __KERNEL__
>> +/* Keep in sync with SG_DEFAULT_TIMEOUT of scsi/sg.h */
>> #define SG_DEFAULT_TIMEOUT (60*HZ) /* HZ == 'jiffies in 1
>> second' */
>> #endif
>
> Is it useful and/or necessary to export this constant ? To me this looks
> like an implementation aspect rather than an aspect of the scsi-sg API.
That's fine, I can remove it.
Paolo
prev parent reply other threads:[~2015-09-25 8:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 13:42 [PATCH v2 0/4] scsi: cleanup ioctl headers and provide UAPI versions Paolo Bonzini
2015-09-17 13:42 ` [PATCH v2 1/4] scsi: remove old-style type names from sg.h Paolo Bonzini
2015-09-17 15:24 ` Bart Van Assche
2015-09-17 15:24 ` Bart Van Assche
2015-09-17 13:42 ` [PATCH v2 2/4] scsi: cleanup scsi/scsi_ioctl.h Paolo Bonzini
2015-09-17 15:27 ` Bart Van Assche
2015-09-17 15:27 ` Bart Van Assche
2015-09-17 13:42 ` [PATCH v2 3/4] scsi: move all obsolete ioctls to scsi/scsi_ioctl.h Paolo Bonzini
2015-09-17 15:26 ` Bart Van Assche
2015-09-17 15:26 ` Bart Van Assche
2015-09-17 13:47 ` [PATCH v2 4/4] scsi: provide UAPI version of scsi/sg.h and scsi/scsi_ioctl.h Paolo Bonzini
2015-09-17 15:32 ` Bart Van Assche
2015-09-17 15:32 ` Bart Van Assche
2015-09-25 8:44 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56050988.5000504@redhat.com \
--to=pbonzini@redhat.com \
--cc=bart.vanassche@sandisk.com \
--cc=hch@lst.de \
--cc=jbottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.