From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfPkY-0006HV-DS for qemu-devel@nongnu.org; Fri, 25 Sep 2015 05:57:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfPkU-0002Zh-68 for qemu-devel@nongnu.org; Fri, 25 Sep 2015 05:57:06 -0400 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:46309 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfPkT-0002ZV-Su for qemu-devel@nongnu.org; Fri, 25 Sep 2015 05:57:02 -0400 Message-ID: <56051A6A.7050109@kamp.de> Date: Fri, 25 Sep 2015 11:56:58 +0200 From: Peter Lieven MIME-Version: 1.0 References: <1443084128-25552-1-git-send-email-kraxel@redhat.com> <1443084128-25552-6-git-send-email-kraxel@redhat.com> In-Reply-To: <1443084128-25552-6-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RfC PATCH 05/10] io: add qio_buffer_move_empty List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org Am 24.09.2015 um 10:42 schrieb Gerd Hoffmann: > Signed-off-by: Gerd Hoffmann > --- > include/io/buffer.h | 10 ++++++++++ > io/buffer.c | 14 ++++++++++++++ > 2 files changed, 24 insertions(+) > > diff --git a/include/io/buffer.h b/include/io/buffer.h > index cffad19..1dddc73 100644 > --- a/include/io/buffer.h > +++ b/include/io/buffer.h > @@ -127,4 +127,14 @@ uint8_t *qio_buffer_end(QIOBuffer *buffer); > */ > gboolean qio_buffer_empty(QIOBuffer *buffer); > > +/** > + * qio_buffer_move_empty: > + * @to: destination buffer object > + * @from: source buffer object > + * > + * Moves buffer, without copying data. 'to' buffer must be empty. > + * 'from' buffer is empty and zero-sized on return. > + */ > +void qio_buffer_move_empty(QIOBuffer *to, QIOBuffer *from); > + > #endif /* QIO_BUFFER_H__ */ > diff --git a/io/buffer.c b/io/buffer.c > index daa3ebf..09ca321 100644 > --- a/io/buffer.c > +++ b/io/buffer.c > @@ -77,3 +77,17 @@ void qio_buffer_advance(QIOBuffer *buffer, size_t len) > (buffer->offset - len)); > buffer->offset -= len; > } > + > +void qio_buffer_move_empty(QIOBuffer *to, QIOBuffer *from) > +{ > + assert(to->offset == 0); > + > + g_free(to->buffer); > + to->offset = from->offset; > + to->capacity = from->capacity; > + to->buffer = from->buffer; > + > + from->offset = 0; > + from->capacity = 0; > + from->buffer = NULL; > +} Reviewed-by: Peter Lieven