From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfPkn-0006f8-FP for qemu-devel@nongnu.org; Fri, 25 Sep 2015 05:57:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfPkm-0002eQ-Dj for qemu-devel@nongnu.org; Fri, 25 Sep 2015 05:57:21 -0400 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:42407 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfPkm-0002eA-3G for qemu-devel@nongnu.org; Fri, 25 Sep 2015 05:57:20 -0400 Message-ID: <56051A7D.2040104@kamp.de> Date: Fri, 25 Sep 2015 11:57:17 +0200 From: Peter Lieven MIME-Version: 1.0 References: <1443084128-25552-1-git-send-email-kraxel@redhat.com> <1443084128-25552-10-git-send-email-kraxel@redhat.com> In-Reply-To: <1443084128-25552-10-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RfC PATCH 09/10] vnc: kill jobs queue buffer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org Am 24.09.2015 um 10:42 schrieb Gerd Hoffmann: > Signed-off-by: Gerd Hoffmann > --- > ui/vnc-jobs.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c > index 7a234da..50e6b37 100644 > --- a/ui/vnc-jobs.c > +++ b/ui/vnc-jobs.c > @@ -54,7 +54,6 @@ struct VncJobQueue { > QemuCond cond; > QemuMutex mutex; > QemuThread thread; > - QIOBuffer buffer; > bool exit; > QTAILQ_HEAD(, VncJob) jobs; > }; > @@ -193,7 +192,6 @@ static void vnc_async_encoding_start(VncState *orig, VncState *local) > local->zlib = orig->zlib; > local->hextile = orig->hextile; > local->zrle = orig->zrle; > - local->output = queue->buffer; > local->csock = -1; /* Don't do any network work on this thread */ > > qio_buffer_reset(&local->output); > @@ -206,8 +204,6 @@ static void vnc_async_encoding_end(VncState *orig, VncState *local) > orig->hextile = local->hextile; > orig->zrle = local->zrle; > orig->lossy_rect = local->lossy_rect; > - > - queue->buffer = local->output; > } > > static int vnc_worker_thread_loop(VncJobQueue *queue) > @@ -303,7 +299,6 @@ static VncJobQueue *vnc_queue_init(void) > > qemu_cond_init(&queue->cond); > qemu_mutex_init(&queue->mutex); > - qio_buffer_init(&queue->buffer, "vnc-job-queue"); > QTAILQ_INIT(&queue->jobs); > return queue; > } > @@ -312,7 +307,6 @@ static void vnc_queue_clear(VncJobQueue *q) > { > qemu_cond_destroy(&queue->cond); > qemu_mutex_destroy(&queue->mutex); > - qio_buffer_free(&queue->buffer); > g_free(q); > queue = NULL; /* Unset global queue */ > } Reviewed-by: Peter Lieven