Re: [Qemu-devel] [PATCH v3 4/7] device-introspect-test: New, covering device introspection

[Thomas Huth <thuth@redhat.com>]

On 24/09/15 20:57, Markus Armbruster wrote:
> The test doesn't check that the output makes any sense, only that QEMU
> survives.  Useful since we've had an astounding number of crash bugs
> around there.
> 
> In fact, we have a bunch of them right now: several devices crash or
> hang, and all CPUs leave a dangling pointer behind.  The test skips
> testing the broken parts.  The next commits will fix them, and drop
> the skipping.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
>  tests/Makefile                 |   8 ++-
>  tests/device-introspect-test.c | 153 +++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 158 insertions(+), 3 deletions(-)
>  create mode 100644 tests/device-introspect-test.c

 Hi Markus,

just a quick note: When I run the tester directly, it aborts:

$ tests/boot-order-test
**
ERROR:/home/thuth/devel/qemu/tests/libqtest.c:517:qtest_get_arch:
assertion failed: (qemu != NULL)
Aborted (core dumped)

... that's a little bit ugly, maybe you could print the help text instead?

 Thomas