From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfTLK-0006sC-B0 for qemu-devel@nongnu.org; Fri, 25 Sep 2015 09:47:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfTLH-0003k3-5b for qemu-devel@nongnu.org; Fri, 25 Sep 2015 09:47:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38736) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfTLH-0003jv-0s for qemu-devel@nongnu.org; Fri, 25 Sep 2015 09:47:15 -0400 References: <1443184788-18859-1-git-send-email-afaerber@suse.de> <1443184788-18859-7-git-send-email-afaerber@suse.de> <56054133.3080108@redhat.com> <56054198.1000400@suse.de> <56054496.6060603@redhat.com> <56054BA4.7040200@suse.de> From: Paolo Bonzini Message-ID: <5605505B.4090507@redhat.com> Date: Fri, 25 Sep 2015 15:47:07 +0200 MIME-Version: 1.0 In-Reply-To: <56054BA4.7040200@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 6/7] cutils: Normalize qemu_strto[u]ll() signature List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Andreas_F=c3=a4rber?= , qemu-devel@nongnu.org Cc: Markus Armbruster , Bruce Rogers , Michael Roth , Lin Ma On 25/09/2015 15:27, Andreas F=C3=A4rber wrote: >> >=20 >> > No, I really mean the types. :) The qemu_strtoll/qemu_strtoull funct= ions >> > use {,u}int64_t because they are much more used than long long and >> > unsigned long long. > Well, my answer still stands: The next patch has code using long long. >=20 > Problem is that uint64_t foo =3D strtoull(...) works, while > qemu_strtoull(..., &foo) causes a pointer mismatch warning treated as > error. I could've converted those to uint64_t (assuming the type is not > needed for something else), but I rather wanted to keep changes small. >=20 > If we want functions using [u]int64_t, we should name them > ...strto[u]64, not mixing C and POSIX types. Good point. Yes, I would prefer the function to be renamed and using uint64_t in string-input-visitor. Paolo > But I assumed there may be some controversy, so I intentionally put thi= s > after the actual bug fixes and test cases, they can easily be dropped. = :)