Re: [Qemu-devel] [PATCH v1] netfilter: various comment fixes

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 929 bytes --]

On 09/25/2015 02:08 AM, Yang Hongyang wrote:
> This patchset addressed Markus comment on netfilter patch
> series, most of them are comment fixes.
> 
> It is based on jason's net tree:
> https://github.com/jasowang/qemu/tree/net

If that tree is not yet merged mainline, wouldn't it be better to squash
these fixes directly into the offending patches, instead of using it as
a followup patch?


>      /*
> -     * we return size when buffer a packet, the sender will take it as
> -     * a already sent packet, so sent_cb should not be called later
> -     * FIXME: even if guest can't receive packet for some reasons. Filter
> +     * We return size when buffer a packet, the sender will take it as
> +     * a already sent packet, so sent_cb should not be called later.

s/a already/an already/

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]