All of lore.kernel.org
 help / color / mirror / Atom feed
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] Documentation: dt: keystone: provide SoC specific compatible flags
Date: Fri, 25 Sep 2015 09:50:07 -0500	[thread overview]
Message-ID: <56055F1F.4060401@ti.com> (raw)
In-Reply-To: <56041CA4.40208@ti.com>

On 09/24/2015 10:54 AM, Murali Karicheri wrote:
[...]
> ti,omap3 is the family of omap3 devices similar to keystone. ti,omap3450
> is required if there is an exceptional treatment required for ti,omap3450.
> 
> In keystone case so far there is no case of exceptional treatment
> required in the code for a specific SoC. So a generic name, ti,keystone
> is used. When exceptional treatment is needed in the future, for example
> k2hk Soc, we should introduce SoC specific string in the following order.

Did you do a grep on the code to see?
$ git grep ti,omap3 arch/arm/mach-omap2/
           arch/arm/mach-omap2/board-generic.c:    "ti,omap3430",
arch/arm/mach-omap2/board-generic.c:    "ti,omap3",
arch/arm/mach-omap2/board-generic.c:    "ti,omap36xx",
arch/arm/mach-omap2/board-generic.c:    "ti,omap3-beagle",

This is the same as keystone's device support. even though only 36xx was
needed, we introduced other SoC specific compatibility match.

> "ti,k2hk-evm", "ti,k2hk", "ti,keystone"
> 
> So unless there is an exception, there is no need for a SoC specific
> string in the compatibility string list. So this can be added later if
> there is need for exceptional treatment. Did I get it wrong?
> 

I see both your views seem to be "if we dont need a compatible" dont add
it. My view was based on "be accurate in the hardware description"

OK - i will probably agree on the topic. But, how about userspace
needing to know which SoC they are on, without needing to depend on
board->soc mapping? How do we help resolve that?

-- 
Regards,
Nishanth Menon

WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
To: Murali Karicheri <m-karicheri2-l0cyMroinI0@public.gmane.org>,
	Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>,
	santosh shilimkar
	<santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	Santosh Shilimkar
	<ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 1/3] Documentation: dt: keystone: provide SoC specific compatible flags
Date: Fri, 25 Sep 2015 09:50:07 -0500	[thread overview]
Message-ID: <56055F1F.4060401@ti.com> (raw)
In-Reply-To: <56041CA4.40208-l0cyMroinI0@public.gmane.org>

On 09/24/2015 10:54 AM, Murali Karicheri wrote:
[...]
> ti,omap3 is the family of omap3 devices similar to keystone. ti,omap3450
> is required if there is an exceptional treatment required for ti,omap3450.
> 
> In keystone case so far there is no case of exceptional treatment
> required in the code for a specific SoC. So a generic name, ti,keystone
> is used. When exceptional treatment is needed in the future, for example
> k2hk Soc, we should introduce SoC specific string in the following order.

Did you do a grep on the code to see?
$ git grep ti,omap3 arch/arm/mach-omap2/
           arch/arm/mach-omap2/board-generic.c:    "ti,omap3430",
arch/arm/mach-omap2/board-generic.c:    "ti,omap3",
arch/arm/mach-omap2/board-generic.c:    "ti,omap36xx",
arch/arm/mach-omap2/board-generic.c:    "ti,omap3-beagle",

This is the same as keystone's device support. even though only 36xx was
needed, we introduced other SoC specific compatibility match.

> "ti,k2hk-evm", "ti,k2hk", "ti,keystone"
> 
> So unless there is an exception, there is no need for a SoC specific
> string in the compatibility string list. So this can be added later if
> there is need for exceptional treatment. Did I get it wrong?
> 

I see both your views seem to be "if we dont need a compatible" dont add
it. My view was based on "be accurate in the hardware description"

OK - i will probably agree on the topic. But, how about userspace
needing to know which SoC they are on, without needing to depend on
board->soc mapping? How do we help resolve that?

-- 
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com>
To: Murali Karicheri <m-karicheri2@ti.com>,
	Nishanth Menon <nm@ti.com>,
	santosh shilimkar <santosh.shilimkar@oracle.com>,
	Santosh Shilimkar <ssantosh@kernel.org>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/3] Documentation: dt: keystone: provide SoC specific compatible flags
Date: Fri, 25 Sep 2015 09:50:07 -0500	[thread overview]
Message-ID: <56055F1F.4060401@ti.com> (raw)
In-Reply-To: <56041CA4.40208@ti.com>

On 09/24/2015 10:54 AM, Murali Karicheri wrote:
[...]
> ti,omap3 is the family of omap3 devices similar to keystone. ti,omap3450
> is required if there is an exceptional treatment required for ti,omap3450.
> 
> In keystone case so far there is no case of exceptional treatment
> required in the code for a specific SoC. So a generic name, ti,keystone
> is used. When exceptional treatment is needed in the future, for example
> k2hk Soc, we should introduce SoC specific string in the following order.

Did you do a grep on the code to see?
$ git grep ti,omap3 arch/arm/mach-omap2/
           arch/arm/mach-omap2/board-generic.c:    "ti,omap3430",
arch/arm/mach-omap2/board-generic.c:    "ti,omap3",
arch/arm/mach-omap2/board-generic.c:    "ti,omap36xx",
arch/arm/mach-omap2/board-generic.c:    "ti,omap3-beagle",

This is the same as keystone's device support. even though only 36xx was
needed, we introduced other SoC specific compatibility match.

> "ti,k2hk-evm", "ti,k2hk", "ti,keystone"
> 
> So unless there is an exception, there is no need for a SoC specific
> string in the compatibility string list. So this can be added later if
> there is need for exceptional treatment. Did I get it wrong?
> 

I see both your views seem to be "if we dont need a compatible" dont add
it. My view was based on "be accurate in the hardware description"

OK - i will probably agree on the topic. But, how about userspace
needing to know which SoC they are on, without needing to depend on
board->soc mapping? How do we help resolve that?

-- 
Regards,
Nishanth Menon

  reply	other threads:[~2015-09-25 14:50 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-22 16:08 [PATCH 0/3] ARM: dts/keystone: Introduce SoC specific compatible matches Nishanth Menon
2015-09-22 16:08 ` Nishanth Menon
2015-09-22 16:08 ` Nishanth Menon
2015-09-22 16:08 ` [PATCH 1/3] Documentation: dt: keystone: provide SoC specific compatible flags Nishanth Menon
2015-09-22 16:08   ` Nishanth Menon
2015-09-22 16:08   ` Nishanth Menon
2015-09-23 18:05   ` Murali Karicheri
2015-09-23 18:05     ` Murali Karicheri
2015-09-23 18:05     ` Murali Karicheri
2015-09-23 19:15     ` Nishanth Menon
2015-09-23 19:15       ` Nishanth Menon
2015-09-23 19:15       ` Nishanth Menon
2015-09-23 18:19   ` santosh shilimkar
2015-09-23 18:19     ` santosh shilimkar
2015-09-23 18:19     ` santosh shilimkar
2015-09-24 14:05     ` Murali Karicheri
2015-09-24 14:05       ` Murali Karicheri
2015-09-24 14:05       ` Murali Karicheri
2015-09-24 14:20       ` Nishanth Menon
2015-09-24 14:20         ` Nishanth Menon
2015-09-24 14:20         ` Nishanth Menon
2015-09-24 15:54         ` Murali Karicheri
2015-09-24 15:54           ` Murali Karicheri
2015-09-24 15:54           ` Murali Karicheri
2015-09-25 14:50           ` Nishanth Menon [this message]
2015-09-25 14:50             ` Nishanth Menon
2015-09-25 14:50             ` Nishanth Menon
2015-09-25 15:18             ` santosh shilimkar
2015-09-25 15:18               ` santosh shilimkar
2015-09-25 16:01               ` Nishanth Menon
2015-09-25 16:01                 ` Nishanth Menon
2015-09-25 16:01                 ` Nishanth Menon
2015-09-25 16:15                 ` santosh shilimkar
2015-09-25 16:15                   ` santosh shilimkar
2015-09-25 16:15                   ` santosh shilimkar
2015-09-25 17:38                   ` Nishanth Menon
2015-09-25 17:38                     ` Nishanth Menon
2015-09-25 17:38                     ` Nishanth Menon
2015-10-02 16:09                     ` santosh shilimkar
2015-10-02 16:09                       ` santosh shilimkar
2015-10-03 23:44                       ` Nishanth Menon
2015-10-03 23:44                         ` Nishanth Menon
2015-10-03 23:44                         ` Nishanth Menon
2015-10-04  0:16                         ` santosh.shilimkar at oracle.com
2015-10-04  0:16                           ` santosh.shilimkar
2015-10-04  0:16                           ` santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA
2015-09-30 14:31                 ` Murali Karicheri
2015-09-30 14:31                   ` Murali Karicheri
2015-09-30 14:31                   ` Murali Karicheri
2015-09-22 16:08 ` [PATCH 2/3] ARM: keystone: Update compatible to have SoC specific matches Nishanth Menon
2015-09-22 16:08   ` Nishanth Menon
2015-09-22 16:08   ` Nishanth Menon
2015-09-22 16:08 ` [PATCH 3/3] ARM: dts: keystone: Update SoC specific compatible flags Nishanth Menon
2015-09-22 16:08   ` Nishanth Menon
2015-09-22 16:08   ` Nishanth Menon
2015-10-03 23:38 ` [PATCH V2 0/3] ARM: dts/keystone: Introduce SoC specific compatible matches Nishanth Menon
2015-10-03 23:38   ` Nishanth Menon
2015-10-03 23:38   ` Nishanth Menon
2015-10-03 23:38   ` [PATCH V2 1/3] Documentation: dt: keystone: provide SoC specific compatible flags Nishanth Menon
2015-10-03 23:38     ` Nishanth Menon
2015-10-03 23:38     ` Nishanth Menon
2015-10-03 23:38   ` [PATCH V2 2/3] ARM: keystone: Update compatible to have SoC specific matches Nishanth Menon
2015-10-03 23:38     ` Nishanth Menon
2015-10-03 23:38     ` Nishanth Menon
2015-10-03 23:38   ` [PATCH V2 3/3] ARM: dts: keystone: Update SoC specific compatible flags Nishanth Menon
2015-10-03 23:38     ` Nishanth Menon
2015-10-03 23:38     ` Nishanth Menon
2015-10-04  0:13   ` [PATCH V2 0/3] ARM: dts/keystone: Introduce SoC specific compatible matches santosh.shilimkar at oracle.com
2015-10-04  0:13     ` santosh.shilimkar
2015-10-04  0:13     ` santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56055F1F.4060401@ti.com \
    --to=nm@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.