From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Patch v2 09/16] ARMv8/FSL_LSCH2: Add FSL_LSCH2 SoC
Date: Fri, 25 Sep 2015 07:53:00 -0700 [thread overview]
Message-ID: <56055FCC.1010506@freescale.com> (raw)
In-Reply-To: <BN3PR0301MB1249AAD6E64646F0BA7FAE3884420@BN3PR0301MB1249.namprd03.prod.outlook.com>
On 09/25/2015 05:28 AM, Hu Mingkai-B21284 wrote:
>
>
>> -----Original Message-----
>> From: Sun York-R58495
>> Sent: Tuesday, September 22, 2015 1:27 AM
>> To: Gong Qianyu-B52263; u-boot at lists.denx.de
>> Cc: Hu Mingkai-B21284; Sun York-R58495; Hou Zhiqiang-B48286; Song Wenbin-
>> B53747; Xie Shaohui-B21989; Wood Scott-B07421; Li Yang-Leo-R58472
>> Subject: Re: [Patch v2 09/16] ARMv8/FSL_LSCH2: Add FSL_LSCH2 SoC
>>
>>
>>
>> On 09/17/2015 12:06 AM, Gong Qianyu wrote:
>>> From: Mingkai Hu <Mingkai.Hu@freescale.com>
>>>
>>> Freescale LayerScape with Chassis Generation 2 is a set of SoCs with
>>> ARMv8 cores and 2rd generation of Chassis.
>>>
>>> Signed-off-by: Li Yang <leoli@freescale.com>
>>> Signed-off-by: Hou Zhiqiang <B48286@freescale.com>
>>> Signed-off-by: Mingkai Hu <Mingkai.Hu@freescale.com>
>>> Signed-off-by: Gong Qianyu <Qianyu.Gong@freescale.com>
>>> ---
>>> V2:
>>> remove FSL_LS102xA_DEVDISR3_PCIE from immap_lsch2.h
>>>
>>> arch/arm/cpu/armv8/Makefile | 1 +
>>> arch/arm/cpu/armv8/fsl-lsch2/Makefile | 12 +
>>> arch/arm/cpu/armv8/fsl-lsch2/README | 10 +
>>> arch/arm/cpu/armv8/fsl-lsch2/cpu.c | 414
>> ++++++++++++++++++
>>
>> Too much duplication. Please work with Alison/Prabhakar to move out the
>> common code in cpu.c.
>>
>
> I agree, there are too much duplications between lsch2 and lsch3:
>
> arch/arm/cpu/armv8/fsl-lsch*
> arch/arm/include/asm/arch-fsl-lsch*
>
> I am considering to consolidate the code between lsch2 and lsch3 using arch-layerscape. The basic idea is to add the following directory for ARMv8 layerscape for the common files and use CONFIG_FSL_LSCH2/ CONFIG_FSL_LSCH3 to differentiate the difference between these two chassis in the same file if necessary.
>
> arch/arm/cpu/armv8/fsl-layerscape
> arch/arm/include/asm/arch-fsl-layerscape/
>
> what is your suggestion?
>
I think it is worth a try.
York
next prev parent reply other threads:[~2015-09-25 14:53 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 7:06 [U-Boot] [Patch v2 04/16] net/fm: bug fix when CONFIG_PHYLIB not defined Gong Qianyu
2015-09-17 7:06 ` [U-Boot] [Patch v2 05/16] net: Move some header files to include/ Gong Qianyu
2015-09-17 18:06 ` Scott Wood
2015-09-17 7:06 ` [U-Boot] [Patch v2 06/16] net/fm: Add QSGMII PCS init Gong Qianyu
2015-09-17 7:06 ` [U-Boot] [Patch v2 07/16] net/fm: fix MDIO controller base on FMAN2 Gong Qianyu
2015-09-17 18:04 ` Scott Wood
2015-09-18 3:49 ` Shaohui Xie
2015-09-18 5:13 ` Scott Wood
2015-09-25 10:51 ` Hu Vincent
2015-09-17 7:06 ` [U-Boot] [Patch v2 08/16] net/fm: fix compile warnings for 64-bit platform Gong Qianyu
2015-09-17 18:13 ` Scott Wood
2015-09-25 2:22 ` Hou Zhiqiang
2015-09-25 2:33 ` Scott Wood
2015-09-25 3:49 ` Hou Zhiqiang
2015-09-17 7:06 ` [U-Boot] [Patch v2 09/16] ARMv8/FSL_LSCH2: Add FSL_LSCH2 SoC Gong Qianyu
2015-09-21 17:27 ` York Sun
2015-09-25 12:28 ` Hu Vincent
2015-09-25 14:53 ` York Sun [this message]
2015-09-27 4:10 ` Kushwaha Prabhakar
2015-09-28 7:23 ` Hu Vincent
2015-09-17 7:06 ` [U-Boot] [Patch v2 10/16] ARMv8/ls1043ardb: Add LS1043ARDB board support Gong Qianyu
2015-09-21 17:27 ` York Sun
2015-09-17 7:06 ` [U-Boot] [Patch v2 11/16] armv8/ls1043ardb: Add nand boot support Gong Qianyu
2015-09-17 20:16 ` Scott Wood
2015-09-18 3:36 ` Gong Q.Y.
2015-09-18 5:14 ` Scott Wood
2015-09-17 7:06 ` [U-Boot] [Patch v2 12/16] armv8/ls1043ardb: Add cpld command to boot from nand Gong Qianyu
2015-09-21 17:27 ` York Sun
2015-09-17 7:06 ` [U-Boot] [Patch v2 13/16] armv8/ls1043a: Add Fman support Gong Qianyu
2015-09-17 7:06 ` [U-Boot] [Patch v2 14/16] armv8/ls1043ardb: esdhc: Add esdhc support for ls1043ardb Gong Qianyu
2015-09-17 7:06 ` [U-Boot] [Patch v2 15/16] armv8/ls1043ardb: Add sd boot support Gong Qianyu
2015-09-17 7:06 ` [U-Boot] [Patch v2 16/16] armv8/ls1043ardb: Add cpld command to boot from sd Gong Qianyu
2015-09-21 17:27 ` York Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56055FCC.1010506@freescale.com \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.