Re: [Qemu-devel] [PATCH 6/7] cutils: Normalize qemu_strto[u]ll() signature

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]

On 09/25/2015 06:39 AM, Andreas Färber wrote:
> Instead of using int64_t for qemu_strtoll() and uiint64_t for

s/uiint64/uint64/

> qemu_strtoull(), use long long and unsigned long long as their name
> implies.
> 
> The only affected callers are our test cases.
> 
> This prepares for following checkpatch's recommendation of using it more,
> by making it easier to switch from POSIX to QEMU versions.
> Remaining difference is const-ness.
> 
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  include/qemu-common.h |  4 +--
>  tests/test-cutils.c   | 76 +++++++++++++++++++++++++--------------------------
>  util/cutils.c         |  4 +--
>  3 files changed, 42 insertions(+), 42 deletions(-)

I concur with Paolo's suggestion to instead rename the functions to make
it obvious that we are parsing [u]int64, since that is more likely to
match the type that the bulk of callers will already have on hand.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]