From: Suzuki.Poulose@arm.com (Suzuki K. Poulose)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm-cci500: Workaround pmu_event_set_period
Date: Fri, 25 Sep 2015 17:09:12 +0100 [thread overview]
Message-ID: <560571A8.6050002@arm.com> (raw)
In-Reply-To: <20150925160546.GQ21513@n2100.arm.linux.org.uk>
On 25/09/15 17:05, Russell King - ARM Linux wrote:
> As you're posting an update to CCI500, I thought I'd hijack this
> thread to complain about the same thing that I complained about
> with CCI400:
>
> +config ARM_CCI500_PMU
> + bool "ARM CCI500 PMU support"
> + default y
> + depends on (ARM && CPU_V7) || ARM64
> + depends on PERF_EVENTS
> + select ARM_CCI_PMU
>
> Why "default y" ? Not all ARMv7 CPUs have the CCI bus, and what it
> means is that when moving forward, it's a pain to remember to turn
> the option off amongst all the other Kconfig questions.
>
> Only make things "default y" if it was something that was built in
> a previous kernel and not building it in a later kernel would cause
> a regression, or where it's absolutely necessary to do so.
Sure, we can turn that off by default. I will send a patch.
Suzuki
next prev parent reply other threads:[~2015-09-25 16:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 15:50 [PATCH] arm-cci500: Workaround pmu_event_set_period Suzuki K. Poulose
2015-09-25 16:05 ` Russell King - ARM Linux
2015-09-25 16:09 ` Suzuki K. Poulose [this message]
2015-09-28 15:38 ` Mark Rutland
2015-09-29 9:13 ` Suzuki K. Poulose
2015-09-29 10:30 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560571A8.6050002@arm.com \
--to=suzuki.poulose@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.