From mboxrd@z Thu Jan 1 00:00:00 1970 From: Icenowy Zheng Subject: Re: [PATCH v3 08/10] dmaengine: sun6i: allow build on ARM64 platforms (sun50i) Date: Thu, 02 Feb 2017 23:50:42 +0800 Message-ID: <5605761486050642@web3m.yandex.ru> References: <20170129023331.62106-1-icenowy@aosc.xyz> <20170129023331.62106-9-icenowy@aosc.xyz> <20170130164210.GD19244@localhost> <3729521485800635@web23g.yandex.ru> <20170131033236.GH19244@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from forward3o.cmail.yandex.net (forward3o.cmail.yandex.net [37.9.109.247]) by alsa0.perex.cz (Postfix) with ESMTP id 36FDC265AF3 for ; Thu, 2 Feb 2017 16:50:43 +0100 (CET) In-Reply-To: <20170131033236.GH19244@localhost> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Vinod Koul Cc: "devicetree@vger.kernel.org" , "alsa-devel@alsa-project.org" , Andre Przywara , Linus Walleij , "linux-sunxi@googlegroups.com" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , Chen-Yu Tsai , Mark Brown , "dmaengine@vger.kernel.org" , Maxime Ripard , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: alsa-devel@alsa-project.org CgozMS4wMS4yMDE3LCAxMTozMiwgIlZpbm9kIEtvdWwiIDx2aW5vZC5rb3VsQGludGVsLmNvbT46 Cj4gT24gVHVlLCBKYW4gMzEsIDIwMTcgYXQgMDI6MjM6NTVBTSArMDgwMCwgSWNlbm93eSBaaGVu ZyB3cm90ZToKPj4gwqAzMS4wMS4yMDE3LCAwMDo0MSwgIlZpbm9kIEtvdWwiIDx2aW5vZC5rb3Vs QGludGVsLmNvbT46Cj4+IMKgPiBPbiBTdW4sIEphbiAyOSwgMjAxNyBhdCAxMDozMzoyOUFNICsw ODAwLCBJY2Vub3d5IFpoZW5nIHdyb3RlOgo+PiDCoD4+IMKgQXMgNjQtYml0IEFsbHdpbm5lciBI NSBTb0MgaGFzIHRoZSBzYW1lIERNQSBlbmdpbmUgd2l0aCBIMywgdGhlIERNQQo+PiDCoD4+IMKg ZHJpdmVyIHNob3VsZCBiZSBhbGxvd2VkIHRvIGJlIGJ1aWx0IGZvciBBUk02NCwgaW4gb3JkZXIg dG8gbWFrZSBpdCB3b3JrIG9uIEg1Lgo+PiDCoD4+Cj4+IMKgPj4gwqBTaWduZWQtb2ZmLWJ5OiBJ Y2Vub3d5IFpoZW5nIDxpY2Vub3d5QGFvc2MueHl6Pgo+PiDCoD4+IMKgQWNrZWQtYnk6IE1heGlt ZSBSaXBhcmQgPG1heGltZS5yaXBhcmRAZnJlZS1lbGVjdHJvbnMuY29tPgo+PiDCoD4+IMKgQWNr ZWQtYnk6IENoZW4tWXUgVHNhaSA8d2Vuc0Bjc2llLm9yZz4KPj4gwqA+PiDCoC0tLQo+PiDCoD4+ IMKgUGF0Y2ggaW50cm9kdWNlZCBiZXR3ZWVuIHYxIGFuZCB2MiwgdG8gc2F0aXNmeSB0aGUgbmV3 bHkgYWRkZWQgSDMvSDUgYXVkaW8KPj4gwqA+PiDCoGNvZGVjIHN1cHBvcnQuCj4+IMKgPj4KPj4g wqA+PiDCoMKgZHJpdmVycy9kbWEvS2NvbmZpZyB8IDIgKy0KPj4gwqA+PiDCoMKgMSBmaWxlIGNo YW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4+IMKgPj4KPj4gwqA+PiDCoGRp ZmYgLS1naXQgYS9kcml2ZXJzL2RtYS9LY29uZmlnIGIvZHJpdmVycy9kbWEvS2NvbmZpZwo+PiDC oD4+IMKgaW5kZXggMGQ2YTk2ZWU5ZmM3Li5kMDFkNTk4MTJjZjMgMTAwNjQ0Cj4+IMKgPj4gwqAt LS0gYS9kcml2ZXJzL2RtYS9LY29uZmlnCj4+IMKgPj4gwqArKysgYi9kcml2ZXJzL2RtYS9LY29u ZmlnCj4+IMKgPj4gwqBAQCAtMTU3LDcgKzE1Nyw3IEBAIGNvbmZpZyBETUFfU1VONEkKPj4gwqA+ Pgo+PiDCoD4+IMKgwqBjb25maWcgRE1BX1NVTjZJCj4+IMKgPj4gwqDCoMKgwqDCoMKgwqDCoMKg wqB0cmlzdGF0ZSAiQWxsd2lubmVyIEEzMSBTb0NzIERNQSBzdXBwb3J0Igo+PiDCoD4+IMKgLSBk ZXBlbmRzIG9uIE1BQ0hfU1VONkkgfHwgTUFDSF9TVU44SSB8fCBDT01QSUxFX1RFU1QKPj4gwqA+ PiDCoCsgZGVwZW5kcyBvbiBNQUNIX1NVTjZJIHx8IE1BQ0hfU1VOOEkgfHwgKEFSTTY0ICYmIEFS Q0hfU1VOWEkpIHx8IENPTVBJTEVfVEVTVAo+PiDCoD4KPj4gwqA+IERvIHdlIHJlYWxseSBuZWVk IEFSTTY0IGhlcmU/IGFsc28gbG9va2luZyBhdCBvdGhlcnMgSSB3b25kZXIgd2h5IGlzbid0Cj4+ IMKgPiB0aGlzIE1BQ0hfU1VOWEkuLi4/Cj4+Cj4+IMKgWW91IG1lYW4gZGlyZWN0bHkgcGxhY2Ug IkFSQ0hfU1VOWEkiIGhlcmU/Cj4+Cj4+IMKgU1VONEkvU1VONUkvU1VON0kgZG8gbm90IHVzZSBE TUFfU1VONkksIHRoZXkgaGF2ZSBkaWZmZXJlbnQgRE1BCj4+IMKgY29udHJvbGxlcnMuCj4KPiBO byBteSBxdWVzdGlvbiB3YXMgZGlmZmVyZW50Li4KPgo+IFdlIGhhdmUgTUFDSF9TVU54eCBmb3Ig NkkgYW5kIDhJLCBzbyB3aHkgZG8gd2UgaGF2ZSBBUkNIX1NVTlhJIGFuZCBpZiBpdHMgYW4KPiBh cmNoIFNVTlhJLCBYIG1lYW5zIGl0IGNhbiB0YWtlIGFueSB2YWx1ZS4uLgo+Cj4gVGhpcyBzY2hl bWEgbG9va3MgcHJldHR5IGNvbmZ1c2luZyB3aGlsZSByZWFkaW5nCgpJdCdzIGEgd2VpcmQgc2No ZW1hIG1hZGUgYnkgdGhlIHZlbmRvci4KCj4gQWxzbyBJIGhhZCBhIHF1ZXN0aW9uIG9uIHVzYWdl IG9mIEFSTTY0Li4KCkZvciBBUk02NCwgd2UgaGF2ZSBubyBNQUNIX1NVTjUwSSwgYXMgdGhlIG9u bHkgQVJNNjQtY2FwYWJsZSBzZXJpZXMgaW4gU1VOWEkKaXMgU1VONTBJLiBTbyBJIHVzZSAoQVJN NjQgJiYgQVJDSF9TVU5YSSkgaGVyZSB0byByZXByZXNlbnQgIk1BQ0hfU1VONTBJIi4KClAuUy4g QWxsd2lubmVyIGhhdmUgc3VuNGkoQTEwKSwgc3VuNWkoQTEzL0ExMHMvR1I4KSwgc3VuNmkoQTMx L0EzMXMpLCBzdW43aShBMjApLApzdW44aShBMjMvQTMzL0gzL1Yzcy9BODNUKSwgc3VuOWkoQTgw KSwgc3VuNTBpKEE2NC9INSkuIEZyb20gdGhlIHN1bjZpCmdlbmVyYXRpb24sIHRoaW5ncyBjaGFu Z2VkIGEgbG90OyBob3dldmVyLCBzdW43aSBpcyBhIGRlcml2YXRpb24gb2Ygc3VuNGkuIEluIFUt Qm9vdCwKZXZlcnkgU29DIGFmdGVyIHN1bjZpIChleGNlcHQgc3VuN2kpIGhhdmUgYW4gb3B0aW9u IENPTkZJR19HRU5fU1VONkkuCgpUaGlzIERNQWVuZ2luZSBkcml2ZXIgaXMgZm9yIHRoZSBuZXcg Z2VuZXJhdGlvbiBETUEgZW5naW5lLgoKU1VONEksIFNVTjVJIGFuZCBTVU43SSBoYXZlIG5vIGhh cmR3YXJlIHRoYXQgdXNlcyBzdWNoIGEgRE1BZW5naW5lLCBzbyBoZXJlJ3MKTUFDSF9TVU42SSB8 fCBNQUNIX1NVTjhJIHx8IChBUk02NCAmJiBBUkNIX1NVTlhJKSwgdG8gcHJldmVudCBpdCB0byBi ZSBidWlsdAppbiBhIGtlcm5lbCB0aGF0IGRvIG5vdCBzdXBwb3J0IGFueSBzeXN0ZW0gd2l0aCBz dWNoIGEgRE1BZW5naW5lLgoKPgo+IC0tCj4gflZpbm9kCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkFsc2EtZGV2ZWwgbWFpbGluZyBsaXN0CkFsc2EtZGV2 ZWxAYWxzYS1wcm9qZWN0Lm9yZwpodHRwOi8vbWFpbG1hbi5hbHNhLXByb2plY3Qub3JnL21haWxt YW4vbGlzdGluZm8vYWxzYS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: icenowy@aosc.xyz (Icenowy Zheng) Date: Thu, 02 Feb 2017 23:50:42 +0800 Subject: [PATCH v3 08/10] dmaengine: sun6i: allow build on ARM64 platforms (sun50i) In-Reply-To: <20170131033236.GH19244@localhost> References: <20170129023331.62106-1-icenowy@aosc.xyz> <20170129023331.62106-9-icenowy@aosc.xyz> <20170130164210.GD19244@localhost> <3729521485800635@web23g.yandex.ru> <20170131033236.GH19244@localhost> Message-ID: <5605761486050642@web3m.yandex.ru> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 31.01.2017, 11:32, "Vinod Koul" : > On Tue, Jan 31, 2017 at 02:23:55AM +0800, Icenowy Zheng wrote: >> ?31.01.2017, 00:41, "Vinod Koul" : >> ?> On Sun, Jan 29, 2017 at 10:33:29AM +0800, Icenowy Zheng wrote: >> ?>> ?As 64-bit Allwinner H5 SoC has the same DMA engine with H3, the DMA >> ?>> ?driver should be allowed to be built for ARM64, in order to make it work on H5. >> ?>> >> ?>> ?Signed-off-by: Icenowy Zheng >> ?>> ?Acked-by: Maxime Ripard >> ?>> ?Acked-by: Chen-Yu Tsai >> ?>> ?--- >> ?>> ?Patch introduced between v1 and v2, to satisfy the newly added H3/H5 audio >> ?>> ?codec support. >> ?>> >> ?>> ??drivers/dma/Kconfig | 2 +- >> ?>> ??1 file changed, 1 insertion(+), 1 deletion(-) >> ?>> >> ?>> ?diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig >> ?>> ?index 0d6a96ee9fc7..d01d59812cf3 100644 >> ?>> ?--- a/drivers/dma/Kconfig >> ?>> ?+++ b/drivers/dma/Kconfig >> ?>> ?@@ -157,7 +157,7 @@ config DMA_SUN4I >> ?>> >> ?>> ??config DMA_SUN6I >> ?>> ??????????tristate "Allwinner A31 SoCs DMA support" >> ?>> ?- depends on MACH_SUN6I || MACH_SUN8I || COMPILE_TEST >> ?>> ?+ depends on MACH_SUN6I || MACH_SUN8I || (ARM64 && ARCH_SUNXI) || COMPILE_TEST >> ?> >> ?> Do we really need ARM64 here? also looking at others I wonder why isn't >> ?> this MACH_SUNXI...? >> >> ?You mean directly place "ARCH_SUNXI" here? >> >> ?SUN4I/SUN5I/SUN7I do not use DMA_SUN6I, they have different DMA >> ?controllers. > > No my question was different.. > > We have MACH_SUNxx for 6I and 8I, so why do we have ARCH_SUNXI and if its an > arch SUNXI, X means it can take any value... > > This schema looks pretty confusing while reading It's a weird schema made by the vendor. > Also I had a question on usage of ARM64.. For ARM64, we have no MACH_SUN50I, as the only ARM64-capable series in SUNXI is SUN50I. So I use (ARM64 && ARCH_SUNXI) here to represent "MACH_SUN50I". P.S. Allwinner have sun4i(A10), sun5i(A13/A10s/GR8), sun6i(A31/A31s), sun7i(A20), sun8i(A23/A33/H3/V3s/A83T), sun9i(A80), sun50i(A64/H5). From the sun6i generation, things changed a lot; however, sun7i is a derivation of sun4i. In U-Boot, every SoC after sun6i (except sun7i) have an option CONFIG_GEN_SUN6I. This DMAengine driver is for the new generation DMA engine. SUN4I, SUN5I and SUN7I have no hardware that uses such a DMAengine, so here's MACH_SUN6I || MACH_SUN8I || (ARM64 && ARCH_SUNXI), to prevent it to be built in a kernel that do not support any system with such a DMAengine. > > -- > ~Vinod