Re: [Qemu-devel] [PATCH v5 45/46] net: Complete qapi-fication of netdev_add

[Paolo Bonzini <pbonzini@redhat.com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256



On 23/09/2015 18:37, Eric Blake wrote:
>>> 
>>> Is this still type-unsafe like the old netdev_add (e.g. accepts
>>> a string for an integer)?
> I did not address that yet; it still needs further patches to
> accept an integer as a port number. I can investigate what
> additional patches are needed along those lines, while still
> preserving back-compat to previously-accepted QMP command lines (it
> may require the use of an 'alternate' type that accepts both int
> and string).  The main goal here was that the command line is
> unchanged, and that now the QMP command is introspectable, even if
> what introspection shows is ugly types.

This in fact is a laudable goal.  However, while changing the command to

{ 'command': 'netdev_add', 'data': 'Netdev', 'box': true, 'gen': false }

for better introspection, you should keep 'gen':'false' and the manual
implementation based on qemu_opts_from_qdict, otherwise you break
backwards-compatibility.

Paolo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJWBXr0AAoJEL/70l94x66DJNUH/24lvns9MJpLv0ycT0+jrwVd
BhlCBatRwISITCX+gRSL5kmC0UNeGUWUB6AaYeCxZtY+Z40lCcOakMf2ZvDOf+Iq
0CvrtXSjEzwf3DxUawso4bcBdQKg1Za1sQsvExGd84VbnsRr+HFKNclYhJGxbiG4
UNPvIFzd+mwod+i2RHooRY/CiDqYDSinlLlp4N6DqjjMQeiTcetJqfdsm6Kke9fg
ntu/YEwlqcgGFSSDOdGG1YmSmWApUOw0gAzHt+Ufyy+I/M6Mzvn9OH6E3lQtghOy
ovK230/8YIoIPBkWsRxYDp1LrmxarszMTqAWMuc3ALRxJSQ6GMrtgDby1ghw1W8=
=akeC
-----END PGP SIGNATURE-----