Re: [Qemu-devel] [RFC 3/6] monitor: Split MonitorQAPIEventConf off MonitorQAPIEventState

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1159 bytes --]

On 09/25/2015 08:00 AM, Markus Armbruster wrote:
> In preparation of turning monitor_qapi_event_state[] into a hash table
> for finer grained throttling.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  monitor.c | 79 ++++++++++++++++++++++++++++++---------------------------------
>  1 file changed, 38 insertions(+), 41 deletions(-)
> 

> -/*
> - * @event: the event ID to be limited
> - * @rate: the rate limit in milliseconds
> - *
> - * Sets a rate limit on a particular event, so no
> - * more than 1 event will be emitted within @rate
> - * milliseconds
> - */
> -static void
> -monitor_qapi_event_throttle(QAPIEvent event, int64_t rate)
> -{

At one point, I think we were considering having the rate be
user-tunable through a qom property, in which case this function is
still nicer than a monitor_qapi_event_conf[] fixed-rate table.  But
since I don't think we ever used it, I'm fine with dropping the
complexity and living with a constant rate.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]