From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfYyu-00065P-G5 for qemu-devel@nongnu.org; Fri, 25 Sep 2015 15:48:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfYyp-0006zy-PV for qemu-devel@nongnu.org; Fri, 25 Sep 2015 15:48:32 -0400 Received: from v220110690675601.yourvserver.net ([37.221.199.173]:40617) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfYyp-0006zV-Ji for qemu-devel@nongnu.org; Fri, 25 Sep 2015 15:48:27 -0400 Message-ID: <5605A507.7080200@weilnetz.de> Date: Fri, 25 Sep 2015 21:48:23 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1440832355-4933-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1440832355-4933-1-git-send-email-sw@weilnetz.de> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] slirp: Fix type casts and format strings in debug code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: QEMU Developer Am 29.08.2015 um 09:12 schrieb Stefan Weil: > Casting pointers to long won't work on 64 bit Windows. > It is not needed with the right format strings. > > Signed-off-by: Stefan Weil > --- > slirp/bootp.c | 12 +++++++++--- > slirp/if.c | 4 ++-- > slirp/ip_icmp.c | 4 ++-- > slirp/ip_input.c | 10 +++++----- > slirp/ip_output.c | 4 ++-- > slirp/mbuf.c | 6 +++--- > slirp/misc.c | 6 +++--- > slirp/sbuf.c | 4 ++-- > slirp/socket.c | 18 +++++++++--------- > slirp/tcp_input.c | 14 +++++++------- > slirp/tcp_output.c | 2 +- > slirp/tcp_subr.c | 16 ++++++++-------- > slirp/udp.c | 6 +++--- > 13 files changed, 56 insertions(+), 50 deletions(-) > Ping? Should I add this patch to my pull queue for Windows? I am afraid that it is too large for qemu-trivial. Regards, Stefan http://patchwork.ozlabs.org/patch/512116/