From: Randy Dunlap <rdunlap@infradead.org>
To: Lee Jones <lee.jones@linaro.org>, linux-kernel@vger.kernel.org
Cc: qipeng.zha@intel.com, dvhart@infradead.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] platform: x86: PMC IPC depends on ACPI
Date: Fri, 25 Sep 2015 18:53:56 -0700 [thread overview]
Message-ID: <5605FAB4.9000606@infradead.org> (raw)
In-Reply-To: <1443199123-13979-1-git-send-email-lee.jones@linaro.org>
On 09/25/15 09:38, Lee Jones wrote:
> This patch solves:
>
> on x86_64:
>
> when CONFIG_ACPI is not enabled:
>
> ../drivers/mfd/intel_soc_pmic_bxtwc.c: In function 'bxtwc_probe':
> ../drivers/mfd/intel_soc_pmic_bxtwc.c:342:2:
> error: implicit declaration of function 'acpi_evaluate_integer' [-Werror=implicit-function-declaration]
> status = acpi_evaluate_integer(handle, "_HRV", NULL, &hrv);
> ^
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Works for me. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> drivers/platform/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index c69bb70..744cb80 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -914,6 +914,7 @@ config PVPANIC
>
> config INTEL_PMC_IPC
> tristate "Intel PMC IPC Driver"
> + depends on ACPI
> ---help---
> This driver provides support for PMC control on some Intel platforms.
> The PMC is an ARC processor which defines IPC commands for communication
>
--
~Randy
next prev parent reply other threads:[~2015-09-26 1:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 16:38 [PATCH] platform: x86: PMC IPC depends on ACPI Lee Jones
2015-09-26 1:53 ` Randy Dunlap [this message]
2015-10-03 16:57 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5605FAB4.9000606@infradead.org \
--to=rdunlap@infradead.org \
--cc=dvhart@infradead.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qipeng.zha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.