Re: [PATCH 10/23] drm/i915: Add gamma correction handlers

From: "Sharma, Shashank" <shashank.sharma@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: annie.j.matheson@intel.com, intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, kausalmalladi@gmail.com,
	daniel.vetter@intel.com
Subject: Re: [PATCH 10/23] drm/i915: Add gamma correction handlers
Date: Sat, 26 Sep 2015 21:18:48 +0530	[thread overview]
Message-ID: <5606BE60.6070901@intel.com> (raw)
In-Reply-To: <5602613D.2070202@intel.com>

On 9/23/2015 1:52 PM, Sharma, Shashank wrote:
>> Since color manager properties are meant as a new standardize KMS
>> extension (we put them into the core drm_crtc_state) the get/set support
>> should also be in the core. See e.g. how the rotation property is handled
>> in drm_atomic_plane_get/set_property. So all this code should be added to
>> drm_atomic_crtc_get/set_property.
> Thanks, sounds like a good one. Will move this.
Actually, while implementing this, I realized that this change is not 
required.
What we want to do in drm_atomic_crtc_get/set code is:
if (prop == config->cm_palette_after_ctm_property || prop == 	
	config->cm_palette_before_ctm_property) {
	crtc->funcs->atomic_get_property();
}

Which is already being done in the current code:
else if (crtc->funcs->atomic_get_property)
	return crtc->funcs->atomic_get_property(crtc, state, property, val);

so I dont really think we need this change.

Regards
Shashank

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx