From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Lin Subject: Re: [RFC PATCH v3 1/3] mmc: sprd: Add MMC host driver for Spreadtrum SoC Date: Mon, 28 Sep 2015 15:37:43 +0800 Message-ID: <5608EE47.1020402@rock-chips.com> References: <1439571353-30165-1-git-send-email-wuht06@gmail.com> <1439571353-30165-2-git-send-email-wuht06@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from lucky1.263xmail.com ([211.157.147.133]:59040 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750864AbbI1HiB (ORCPT ); Mon, 28 Sep 2015 03:38:01 -0400 In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Hongtao Wu Cc: Ulf Hansson , shawn.lin@rock-chips.com, linux-mmc , "linux-kernel@vger.kernel.org" , Rob Herring , =?UTF-8?Q?Pawe=c5=82_Moll?= , Mark Rutland , Ian Campbell , Kumar Gala , "devicetree@vger.kernel.org" , Catalin Marinas , Will Deacon , "linux-arm-kernel@lists.infradead.org" , "Orson.Zhai@spreadtrum.com" , "Chunyan.Zhang@spreadtrum.com" , "Jason.Wu@spreadtrum.com" On 2015/9/28 15:18, Hongtao Wu wrote: > >> > > On Thu, Sep 10, 2015 at 9:28 PM, Ulf Hansson > wrote: > > > > On 14 August 2015 at 18:55, Hongtao Wu > wrote: [...] > > Yes, most of this data can be removed, such as caps, caps2, base_clk. > However ocr_avail and signal_default_voltage are useful for us. > We can't fetch ocr_avail from external regulator via > mmc_regulator_get_supply, > because our regulator driver can't supply mmc_regulator_get_ocrmask() > interface for MMC driver. Sorry for the noise but... IMO, your need to quirk your regulator driver stuffs rather than mmc. > And sometimes our external regulator can not supply 3.0v or 1.8v default > signal voltage that we expect. So this 3.0v or 1.8v default signal > voltage are > mandatory. > -- Best Regards Shawn Lin From mboxrd@z Thu Jan 1 00:00:00 1970 From: shawn.lin@rock-chips.com (Shawn Lin) Date: Mon, 28 Sep 2015 15:37:43 +0800 Subject: [RFC PATCH v3 1/3] mmc: sprd: Add MMC host driver for Spreadtrum SoC In-Reply-To: References: <1439571353-30165-1-git-send-email-wuht06@gmail.com> <1439571353-30165-2-git-send-email-wuht06@gmail.com> Message-ID: <5608EE47.1020402@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015/9/28 15:18, Hongtao Wu wrote: > >> > > On Thu, Sep 10, 2015 at 9:28 PM, Ulf Hansson > wrote: > > > > On 14 August 2015 at 18:55, Hongtao Wu > wrote: [...] > > Yes, most of this data can be removed, such as caps, caps2, base_clk. > However ocr_avail and signal_default_voltage are useful for us. > We can't fetch ocr_avail from external regulator via > mmc_regulator_get_supply, > because our regulator driver can't supply mmc_regulator_get_ocrmask() > interface for MMC driver. Sorry for the noise but... IMO, your need to quirk your regulator driver stuffs rather than mmc. > And sometimes our external regulator can not supply 3.0v or 1.8v default > signal voltage that we expect. So this 3.0v or 1.8v default signal > voltage are > mandatory. > -- Best Regards Shawn Lin