From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tero Kristo Subject: Re: [PATCH 07/17] ARM: dts: am4372: add reset data Date: Mon, 28 Sep 2015 11:11:08 +0300 Message-ID: <5608F61C.30508@ti.com> References: <1443104818-993-1-git-send-email-t-kristo@ti.com> <1443104818-993-8-git-send-email-t-kristo@ti.com> <560544B3.3090805@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <560544B3.3090805@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Lokesh Vutla , linux-omap@vger.kernel.org, tony@atomide.com, s-anna@ti.com, paul@pwsan.com Cc: linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org On 09/25/2015 03:57 PM, Lokesh Vutla wrote: > Hi Tero, > > On Thursday 24 September 2015 07:56 PM, Tero Kristo wrote: >> Add reset data for pruss, gfx, wkup-m3 and system reset. >> >> Signed-off-by: Tero Kristo >> --- >> arch/arm/boot/dts/am4372.dtsi | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi >> index 0447c04a..fcc8d31 100644 >> --- a/arch/arm/boot/dts/am4372.dtsi >> +++ b/arch/arm/boot/dts/am4372.dtsi >> @@ -116,12 +116,15 @@ >> reg-names = "umem", "dmem"; >> ti,hwmods = "wkup_m3"; >> ti,pm-firmware = "am335x-pm-firmware.elf"; >> + reset-names = "wkup_m3"; >> + resets = <&prcm 0x2000 0x10 3 0x14 5>; >> }; >> >> prcm: prcm@1f0000 { >> compatible = "ti,am4-prcm"; >> reg = <0x1f0000 0x11000>; >> interrupts = ; >> + #reset-cells = <5>; >> >> prcm_clocks: clocks { >> #address-cells = <1>; >> @@ -130,6 +133,12 @@ >> >> prcm_clockdomains: clockdomains { >> }; >> + >> + system_reset: system_reset { >> + compatible = "ti,system-reset"; >> + reset-names = "system"; >> + reset-cells = <&prcm 0x4000 0 0 4 0>; > This should be resets instead of reset-cells. > With this change, reboot is functional on AM437x GP evm. Oops, nasty typo there. Thanks for catching. -Tero > > Thanks and regards, > Lokesh > From mboxrd@z Thu Jan 1 00:00:00 1970 From: t-kristo@ti.com (Tero Kristo) Date: Mon, 28 Sep 2015 11:11:08 +0300 Subject: [PATCH 07/17] ARM: dts: am4372: add reset data In-Reply-To: <560544B3.3090805@ti.com> References: <1443104818-993-1-git-send-email-t-kristo@ti.com> <1443104818-993-8-git-send-email-t-kristo@ti.com> <560544B3.3090805@ti.com> Message-ID: <5608F61C.30508@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09/25/2015 03:57 PM, Lokesh Vutla wrote: > Hi Tero, > > On Thursday 24 September 2015 07:56 PM, Tero Kristo wrote: >> Add reset data for pruss, gfx, wkup-m3 and system reset. >> >> Signed-off-by: Tero Kristo >> --- >> arch/arm/boot/dts/am4372.dtsi | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi >> index 0447c04a..fcc8d31 100644 >> --- a/arch/arm/boot/dts/am4372.dtsi >> +++ b/arch/arm/boot/dts/am4372.dtsi >> @@ -116,12 +116,15 @@ >> reg-names = "umem", "dmem"; >> ti,hwmods = "wkup_m3"; >> ti,pm-firmware = "am335x-pm-firmware.elf"; >> + reset-names = "wkup_m3"; >> + resets = <&prcm 0x2000 0x10 3 0x14 5>; >> }; >> >> prcm: prcm at 1f0000 { >> compatible = "ti,am4-prcm"; >> reg = <0x1f0000 0x11000>; >> interrupts = ; >> + #reset-cells = <5>; >> >> prcm_clocks: clocks { >> #address-cells = <1>; >> @@ -130,6 +133,12 @@ >> >> prcm_clockdomains: clockdomains { >> }; >> + >> + system_reset: system_reset { >> + compatible = "ti,system-reset"; >> + reset-names = "system"; >> + reset-cells = <&prcm 0x4000 0 0 4 0>; > This should be resets instead of reset-cells. > With this change, reboot is functional on AM437x GP evm. Oops, nasty typo there. Thanks for catching. -Tero > > Thanks and regards, > Lokesh >