From mboxrd@z Thu Jan 1 00:00:00 1970 From: thunder.leizhen@huawei.com (Leizhen (ThunderTown)) Date: Mon, 28 Sep 2015 16:41:19 +0800 Subject: [PATCH 2/2] arm64: to allow EFI_RTC can be selected on ARM64 In-Reply-To: References: <1443418478-8240-1-git-send-email-thunder.leizhen@huawei.com> <1443418478-8240-3-git-send-email-thunder.leizhen@huawei.com> Message-ID: <5608FD2F.1000105@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015/9/28 15:40, Ard Biesheuvel wrote: > On 28 September 2015 at 06:34, Zhen Lei wrote: >> Now, ARM64 is also support EFI startup. We hope use EFI runtime services >> to get/set current time and date. >> >> RTC_LIB only controls some configs in drivers/char/Kconfig(included >> EFI_RTC), and will be automatically selected when RTC_CLASS opened. So >> this patch have no functional change but give an opportunity to select >> EFI_RTC when RTC_CLASS closed. >> >> Signed-off-by: Zhen Lei >> --- >> arch/arm64/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >> index 07d1811..25cec57 100644 >> --- a/arch/arm64/Kconfig >> +++ b/arch/arm64/Kconfig >> @@ -85,7 +85,7 @@ config ARM64 >> select PERF_USE_VMALLOC >> select POWER_RESET >> select POWER_SUPPLY >> - select RTC_LIB >> + select RTC_LIB if !EFI >> select SPARSE_IRQ >> select SYSCTL_EXCEPTION_TRACE >> select HAVE_CONTEXT_TRACKING > > You can currently enable EFI_RTC just fine on arm64 when EFI is enabled. > Why exactly do you need this patch on top? Because when we run "make ARCH=arm64 menuconfig", RTC_LIB is always selected. And we have no opportunity to deselect it. And EFI_RTC can be displayed only when RTC_LIB=n. --------drivers/rtc/Kconfig------- config RTC_LIB bool menuconfig RTC_CLASS bool "Real Time Clock" default n depends on !S390 && !UML select RTC_LIB --------------drivers/char/Kconfig-------------- if RTC_LIB=n ...... config EFI_RTC bool "EFI Real Time Clock Services" depends on IA64 || ARM64 ....... endif # RTC_LIB > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932165AbbI1Irt (ORCPT ); Mon, 28 Sep 2015 04:47:49 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:63713 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753995AbbI1Irr (ORCPT ); Mon, 28 Sep 2015 04:47:47 -0400 Subject: Re: [PATCH 2/2] arm64: to allow EFI_RTC can be selected on ARM64 To: Ard Biesheuvel References: <1443418478-8240-1-git-send-email-thunder.leizhen@huawei.com> <1443418478-8240-3-git-send-email-thunder.leizhen@huawei.com> CC: Catalin Marinas , Will Deacon , linux-arm-kernel , Arnd Bergmann , "Greg Kroah-Hartman" , linux-kernel , Kefeng Wang , Xinwei Hu , Zefan Li , Tianhong Ding , Hanjun Guo From: "Leizhen (ThunderTown)" Message-ID: <5608FD2F.1000105@huawei.com> Date: Mon, 28 Sep 2015 16:41:19 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.23.164] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090203.5608FD43.0005,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: d2147aef47e7f04ca952332879e54ca0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/9/28 15:40, Ard Biesheuvel wrote: > On 28 September 2015 at 06:34, Zhen Lei wrote: >> Now, ARM64 is also support EFI startup. We hope use EFI runtime services >> to get/set current time and date. >> >> RTC_LIB only controls some configs in drivers/char/Kconfig(included >> EFI_RTC), and will be automatically selected when RTC_CLASS opened. So >> this patch have no functional change but give an opportunity to select >> EFI_RTC when RTC_CLASS closed. >> >> Signed-off-by: Zhen Lei >> --- >> arch/arm64/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >> index 07d1811..25cec57 100644 >> --- a/arch/arm64/Kconfig >> +++ b/arch/arm64/Kconfig >> @@ -85,7 +85,7 @@ config ARM64 >> select PERF_USE_VMALLOC >> select POWER_RESET >> select POWER_SUPPLY >> - select RTC_LIB >> + select RTC_LIB if !EFI >> select SPARSE_IRQ >> select SYSCTL_EXCEPTION_TRACE >> select HAVE_CONTEXT_TRACKING > > You can currently enable EFI_RTC just fine on arm64 when EFI is enabled. > Why exactly do you need this patch on top? Because when we run "make ARCH=arm64 menuconfig", RTC_LIB is always selected. And we have no opportunity to deselect it. And EFI_RTC can be displayed only when RTC_LIB=n. --------drivers/rtc/Kconfig------- config RTC_LIB bool menuconfig RTC_CLASS bool "Real Time Clock" default n depends on !S390 && !UML select RTC_LIB --------------drivers/char/Kconfig-------------- if RTC_LIB=n ...... config EFI_RTC bool "EFI Real Time Clock Services" depends on IA64 || ARM64 ....... endif # RTC_LIB > > . >