From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Razvan Cojocaru <rcojocaru@bitdefender.com>, xen-devel@lists.xen.org
Cc: tamas@tklengyel.com, keir@xen.org, ian.campbell@citrix.com,
ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.co,
stefano.stabellini@citrix.com, jbeulich@suse.com,
wei.liu2@citrix.com
Subject: Re: [PATCH V3 2/2] xen: Introduce VM_EVENT_FLAG_SET_REGISTERS
Date: Mon, 28 Sep 2015 11:26:04 +0100 [thread overview]
Message-ID: <560915BC.10205@citrix.com> (raw)
In-Reply-To: <1443435382-3817-3-git-send-email-rcojocaru@bitdefender.com>
On 28/09/15 11:16, Razvan Cojocaru wrote:
> diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h
> index ff2f217..3e4efad 100644
> --- a/xen/include/public/vm_event.h
> +++ b/xen/include/public/vm_event.h
> @@ -89,6 +89,12 @@
> * by the altp2m_idx response field if possible.
> */
> #define VM_EVENT_FLAG_ALTERNATE_P2M (1 << 7)
> +/*
> + * Set the vCPU registers to the values in the vm_event response.
> + * Applies to EAX-EDX, ESP, EBP, ESI, EDI, R8-R15, EFLAGS, and EIP.
> + * Requires the vCPU to be paused already (synchronous events only).
> + */
The set registers are architecture specific, or will be if/when ARM
gains support.
It is fine to list the architecture specific bits here (as there are no
more appropriate places for it to live) but do explicitly call out that
the 2nd sentence in x86 specific.
Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
next prev parent reply other threads:[~2015-09-28 10:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 10:16 [PATCH V3 0/2] Introspection optimization helpers Razvan Cojocaru
2015-09-28 10:16 ` [PATCH V3 1/2] xen, libxc: Fine grained control of REP emulation optimizations Razvan Cojocaru
2015-09-28 10:36 ` Andrew Cooper
2015-09-28 10:16 ` [PATCH V3 2/2] xen: Introduce VM_EVENT_FLAG_SET_REGISTERS Razvan Cojocaru
2015-09-28 10:26 ` Andrew Cooper [this message]
2015-09-28 12:00 ` Razvan Cojocaru
2015-09-28 15:25 ` Jan Beulich
2015-09-28 15:55 ` Razvan Cojocaru
2015-09-28 18:46 ` Tamas K Lengyel
2015-09-29 6:36 ` Jan Beulich
2015-09-28 15:57 ` Andrew Cooper
2015-09-28 16:06 ` Jan Beulich
2015-09-28 18:39 ` Tamas K Lengyel
2015-09-29 14:53 ` Tamas K Lengyel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560915BC.10205@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=rcojocaru@bitdefender.com \
--cc=stefano.stabellini@citrix.com \
--cc=stefano.stabellini@eu.citrix.co \
--cc=tamas@tklengyel.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.