From mboxrd@z Thu Jan 1 00:00:00 1970 From: Razvan Cojocaru Subject: Re: [PATCH V3 2/2] xen: Introduce VM_EVENT_FLAG_SET_REGISTERS Date: Mon, 28 Sep 2015 15:00:53 +0300 Message-ID: <56092BF5.6050605@bitdefender.com> References: <1443435382-3817-1-git-send-email-rcojocaru@bitdefender.com> <1443435382-3817-3-git-send-email-rcojocaru@bitdefender.com> <560915BC.10205@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <560915BC.10205@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper , xen-devel@lists.xen.org Cc: tamas@tklengyel.com, keir@xen.org, ian.campbell@citrix.com, ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.co, stefano.stabellini@citrix.com, jbeulich@suse.com, wei.liu2@citrix.com List-Id: xen-devel@lists.xenproject.org On 09/28/2015 01:26 PM, Andrew Cooper wrote: > On 28/09/15 11:16, Razvan Cojocaru wrote: >> diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h >> index ff2f217..3e4efad 100644 >> --- a/xen/include/public/vm_event.h >> +++ b/xen/include/public/vm_event.h >> @@ -89,6 +89,12 @@ >> * by the altp2m_idx response field if possible. >> */ >> #define VM_EVENT_FLAG_ALTERNATE_P2M (1 << 7) >> +/* >> + * Set the vCPU registers to the values in the vm_event response. >> + * Applies to EAX-EDX, ESP, EBP, ESI, EDI, R8-R15, EFLAGS, and EIP. >> + * Requires the vCPU to be paused already (synchronous events only). >> + */ > > The set registers are architecture specific, or will be if/when ARM > gains support. > > It is fine to list the architecture specific bits here (as there are no > more appropriate places for it to live) but do explicitly call out that > the 2nd sentence in x86 specific. > > Otherwise, Reviewed-by: Andrew Cooper Will do in the next version. Thanks for the review, Razvan