All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] simplify configfs attributes
Date: Mon, 28 Sep 2015 14:12:43 +0200	[thread overview]
Message-ID: <56092EBB.3040603@samsung.com> (raw)
In-Reply-To: <1443189000-13398-1-git-send-email-hch@lst.de>

Hi Christoph,

W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze:
> This series consolidates the code to implement configfs attributes
> by providing the ->show and ->store method in common code and using
> container_of in the methods to access the containing structure.
>
> This reduces source and binary size of configfs consumers a lot.
>

Thank you for this series. It is definitely the way to go.
I reviewed it as far as the configfs consumers which I wrote
or have experience with are concerned. There are some minor
issues which you perhaps can call nitpicks. In the last patch
(23/23) I think you meant something different when changing
the documentation - please see my response to that patch.

But otherwise this series is very welcome.

AP



WARNING: multiple messages have this Message-ID (diff)
From: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
To: Christoph Hellwig <hch@lst.de>, Joel Becker <jlbec@evilplan.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Felipe Balbi <balbi@ti.com>, Tejun Heo <tj@kernel.org>,
	Pratyush Anand <pratyush.anand@gmail.com>,
	target-devel@vger.kernel.org, cluster-devel@redhat.com,
	ocfs2-devel@oss.oracle.com, linux-usb@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: simplify configfs attributes
Date: Mon, 28 Sep 2015 14:12:43 +0200	[thread overview]
Message-ID: <56092EBB.3040603@samsung.com> (raw)
In-Reply-To: <1443189000-13398-1-git-send-email-hch@lst.de>

Hi Christoph,

W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze:
> This series consolidates the code to implement configfs attributes
> by providing the ->show and ->store method in common code and using
> container_of in the methods to access the containing structure.
>
> This reduces source and binary size of configfs consumers a lot.
>

Thank you for this series. It is definitely the way to go.
I reviewed it as far as the configfs consumers which I wrote
or have experience with are concerned. There are some minor
issues which you perhaps can call nitpicks. In the last patch
(23/23) I think you meant something different when changing
the documentation - please see my response to that patch.

But otherwise this series is very welcome.

AP

  parent reply	other threads:[~2015-09-28 12:12 UTC|newest]

Thread overview: 161+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-25 13:49 [Cluster-devel] simplify configfs attributes Christoph Hellwig
2015-09-25 13:49 ` Christoph Hellwig
2015-09-25 13:49 ` [Ocfs2-devel] " Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] [PATCH 01/23] configfs: add show and store methods to struct configfs_attribute Christoph Hellwig
2015-09-25 13:49   ` Christoph Hellwig
2015-09-25 13:49   ` [Ocfs2-devel] " Christoph Hellwig
2015-09-25 14:28   ` [Cluster-devel] " Tejun Heo
2015-09-25 14:28     ` Tejun Heo
2015-09-25 17:41     ` [Cluster-devel] " Greg KH
2015-09-25 17:41       ` Greg KH
2015-09-25 17:41       ` [Ocfs2-devel] " Greg KH
2015-09-26 23:38   ` [Cluster-devel] " Nicholas A. Bellinger
2015-09-26 23:38     ` Nicholas A. Bellinger
2015-09-25 13:49 ` [Cluster-devel] [PATCH 02/23] usb-gadget: use per-attribute show and store methods Christoph Hellwig
2015-09-25 13:49   ` Christoph Hellwig
2015-09-25 13:49   ` [Ocfs2-devel] " Christoph Hellwig
2015-09-27 15:47   ` [Cluster-devel] " Felipe Balbi
2015-09-27 15:47     ` Felipe Balbi
2015-09-28 13:33     ` [Cluster-devel] " Christoph Hellwig
2015-09-28 13:33       ` Christoph Hellwig
2015-09-28 13:33       ` [Ocfs2-devel] " Christoph Hellwig
2015-10-01 17:23       ` [Cluster-devel] " Felipe Balbi
2015-10-01 17:23         ` Felipe Balbi
2015-09-27 15:50   ` [Cluster-devel] " Felipe Balbi
2015-09-27 15:50     ` Felipe Balbi
2015-09-28 13:35     ` [Cluster-devel] " Christoph Hellwig
2015-09-28 13:35       ` Christoph Hellwig
2015-09-28 13:35       ` [Ocfs2-devel] " Christoph Hellwig
2015-09-30 16:19       ` [Cluster-devel] " Felipe Balbi
2015-09-30 16:19         ` Felipe Balbi
2015-09-30 16:20         ` [Cluster-devel] " Tejun Heo
2015-09-30 16:20           ` Tejun Heo
2015-09-30 16:32           ` [Cluster-devel] " Felipe Balbi
2015-09-30 16:32             ` Felipe Balbi
2015-09-30 16:35             ` [Cluster-devel] " Tejun Heo
2015-09-30 16:35               ` Tejun Heo
2015-09-30 16:43               ` [Cluster-devel] " Felipe Balbi
2015-09-30 16:43                 ` Felipe Balbi
2015-09-30 16:59                 ` [Cluster-devel] " Tejun Heo
2015-09-30 16:59                   ` Tejun Heo
2015-09-28 10:54   ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-28 10:54     ` Andrzej Pietrasiewicz
2015-09-25 13:49 ` [Cluster-devel] [PATCH 03/23] usb-gadget/uvc: " Christoph Hellwig
2015-09-25 13:49   ` Christoph Hellwig
2015-09-25 13:49   ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 11:35   ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-28 11:35     ` Andrzej Pietrasiewicz
2015-09-28 13:39     ` [Cluster-devel] " Christoph Hellwig
2015-09-28 13:39       ` Christoph Hellwig
2015-09-28 13:39       ` [Ocfs2-devel] " Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] [PATCH 04/23] usb-gadget/f_hid: " Christoph Hellwig
2015-09-25 13:49   ` Christoph Hellwig
2015-09-25 13:49   ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 11:37   ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-28 11:37     ` Andrzej Pietrasiewicz
2015-09-25 13:49 ` [Cluster-devel] [PATCH 05/23] usb-gadget/f_acm: " Christoph Hellwig
2015-09-25 13:49   ` Christoph Hellwig
2015-09-25 13:49   ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 11:39   ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-28 11:39     ` Andrzej Pietrasiewicz
2015-09-25 13:49 ` [Cluster-devel] [PATCH 06/23] usb-gadget/ether: " Christoph Hellwig
2015-09-25 13:49   ` Christoph Hellwig
2015-09-25 13:49   ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 11:40   ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-28 11:40     ` Andrzej Pietrasiewicz
2015-09-25 13:49 ` [Cluster-devel] [PATCH 07/23] usb-gadget/f_loopback: " Christoph Hellwig
2015-09-25 13:49   ` Christoph Hellwig
2015-09-25 13:49   ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 11:46   ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-28 11:46     ` Andrzej Pietrasiewicz
2015-09-28 13:41     ` [Cluster-devel] " Christoph Hellwig
2015-09-28 13:41       ` Christoph Hellwig
2015-09-28 13:41       ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 13:52       ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-28 13:52         ` Andrzej Pietrasiewicz
2015-09-25 13:49 ` [Cluster-devel] [PATCH 08/23] usb-gadget/f_midi: " Christoph Hellwig
2015-09-25 13:49   ` Christoph Hellwig
2015-09-25 13:49   ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 11:47   ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-28 11:47     ` Andrzej Pietrasiewicz
2015-09-25 13:49 ` [Cluster-devel] [PATCH 09/23] usb-gadget/f_printer: " Christoph Hellwig
2015-09-25 13:49   ` Christoph Hellwig
2015-09-25 13:49   ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 11:50   ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-28 11:50     ` Andrzej Pietrasiewicz
2015-09-25 13:49 ` [Cluster-devel] [PATCH 10/23] usb-gadget/f_sourcesink: " Christoph Hellwig
2015-09-25 13:49   ` Christoph Hellwig
2015-09-25 13:49   ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 11:51   ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-28 11:51     ` Andrzej Pietrasiewicz
2015-09-25 13:49 ` [Cluster-devel] [PATCH 11/23] usb-gadget/f_mass_storage: " Christoph Hellwig
2015-09-25 13:49   ` Christoph Hellwig
2015-09-25 13:49   ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 11:53   ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-28 11:53     ` Andrzej Pietrasiewicz
2015-09-25 13:49 ` [Cluster-devel] [PATCH 12/23] usb-gadget/f_ac1: " Christoph Hellwig
2015-09-25 13:49   ` Christoph Hellwig
2015-09-25 13:49   ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 11:56   ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-28 11:56     ` Andrzej Pietrasiewicz
2015-09-25 13:49 ` [Cluster-devel] [PATCH 13/23] usb-gadget/f_uac2: " Christoph Hellwig
2015-09-25 13:49   ` Christoph Hellwig
2015-09-25 13:49   ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 11:56   ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-28 11:56     ` Andrzej Pietrasiewicz
2015-09-25 13:49 ` [Cluster-devel] [PATCH 14/23] usb-gadget/f_obex: " Christoph Hellwig
2015-09-25 13:49   ` Christoph Hellwig
2015-09-25 13:49   ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 11:57   ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-28 11:57     ` Andrzej Pietrasiewicz
2015-09-25 13:49 ` [Cluster-devel] [PATCH 15/23] usb-gadget/f_phonet: " Christoph Hellwig
2015-09-25 13:49   ` Christoph Hellwig
2015-09-25 13:49   ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 11:59   ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-28 11:59     ` Andrzej Pietrasiewicz
2015-09-25 13:49 ` [Cluster-devel] [PATCH 16/23] usb-gadget/f_serial: " Christoph Hellwig
2015-09-25 13:49   ` Christoph Hellwig
2015-09-25 13:49   ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 11:59   ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-28 11:59     ` Andrzej Pietrasiewicz
2015-09-25 13:49 ` [Cluster-devel] [PATCH 17/23] dlm: " Christoph Hellwig
2015-09-25 13:49   ` Christoph Hellwig
2015-09-25 13:49   ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 14:49   ` [Cluster-devel] " David Teigland
2015-09-28 14:49     ` David Teigland
2015-09-28 14:49     ` [Ocfs2-devel] [Cluster-devel] " David Teigland
2015-09-25 13:49 ` [Cluster-devel] [PATCH 18/23] spear13xx_pcie_gadget: " Christoph Hellwig
2015-09-25 13:49   ` Christoph Hellwig
2015-09-25 13:49   ` [Ocfs2-devel] " Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] [PATCH 19/23] target: " Christoph Hellwig
2015-09-25 13:49   ` Christoph Hellwig
2015-09-25 13:49   ` [Ocfs2-devel] " Christoph Hellwig
2015-09-26 23:35   ` [Cluster-devel] " Nicholas A. Bellinger
2015-09-26 23:35     ` Nicholas A. Bellinger
2015-09-25 13:49 ` [Cluster-devel] [PATCH 20/23] netconsole: " Christoph Hellwig
2015-09-25 13:49   ` Christoph Hellwig
2015-09-25 13:49   ` [Ocfs2-devel] " Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] [PATCH 21/23] ocfs2/cluster: move locking into attribute " Christoph Hellwig
2015-09-25 13:49   ` Christoph Hellwig
2015-09-25 13:49   ` [Ocfs2-devel] " Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] [PATCH 22/23] ocfs2/cluster: use per-attribute show and " Christoph Hellwig
2015-09-25 13:49   ` Christoph Hellwig
2015-09-25 13:49   ` [Ocfs2-devel] " Christoph Hellwig
2015-09-25 13:50 ` [Cluster-devel] [PATCH 23/23] configfs: remove old API Christoph Hellwig
2015-09-25 13:50   ` Christoph Hellwig
2015-09-25 13:50   ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 12:06   ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-28 12:06     ` Andrzej Pietrasiewicz
2015-09-28 13:42     ` [Cluster-devel] " Christoph Hellwig
2015-09-28 13:42       ` Christoph Hellwig
2015-09-28 13:42       ` [Ocfs2-devel] " Christoph Hellwig
2015-09-25 13:57 ` [Cluster-devel] simplify configfs attributes Christoph Hellwig
2015-09-25 13:57   ` Christoph Hellwig
2015-09-25 13:57   ` [Ocfs2-devel] " Christoph Hellwig
2015-09-26 23:49 ` [Cluster-devel] " Nicholas A. Bellinger
2015-09-26 23:49   ` Nicholas A. Bellinger
2015-09-27  6:30   ` [Cluster-devel] " Christoph Hellwig
2015-09-27  6:30     ` Christoph Hellwig
2015-09-27  6:30     ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 12:12 ` Andrzej Pietrasiewicz [this message]
2015-09-28 12:12   ` Andrzej Pietrasiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56092EBB.3040603@samsung.com \
    --to=andrzej.p@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.