All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Andreas Dannenberg <dannenberg@ti.com>,
	Sebastian Reichel <sre@kernel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Laurentiu Palcu <laurentiu.palcu@intel.com>
Cc: Ramakrishna Pallala <ramakrishna.pallala@intel.com>,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-api@vger.kernel.org
Subject: Re: [PATCH v7 00/15] power: bq24257: Add support for bq24250/bq24251
Date: Mon, 28 Sep 2015 21:14:33 +0900	[thread overview]
Message-ID: <56092F29.8060106@samsung.com> (raw)
In-Reply-To: <1443196460-26156-1-git-send-email-dannenberg@ti.com>

W dniu 26.09.2015 o 00:54, Andreas Dannenberg pisze:
> This patch series extends the driver to also support bq24250/bq24251.
> 
> The bq24250/251/257 devices have a very similar feature set and are
> virtually identical from a control register point of view so it made
> sense to extend the existing driver rather than submitting a new driver.
> In addition to the new device support the driver is also extended to
> allow access to some device features previously hidden. Basic and
> potentially dangerous charger config parameters affecting the actual
> charging of the Li-Ion battery are only configurable through firmware
> rather than sysfs properties. However some newly introduced properties
> are exposed through sysfs properties as access to them may be desired
> from userspace. For example, it is now possible to manually configure
> the maximum current drawn from the input source to accommodate different
> chargers (0.5A, 1.5A, 2.0A and so on) based on system knowledge a
> userspace application may have rather than rely on the auto-detection
> mechanism that may not work in all possible scenarios.
> 
> Note that most patches have dependencies on other patches in the series.
> 
> v7:
> - Fixed an issue that would have impacted running bisect on the series
>   and double checked the entire series builds one by one by running
>   a git rebase -i --exec="make ..." ... on the Kernel tree
> - Minor simplification of a return from a function
> 
> v6:
> - Removed the ability to configure the IRQ through "stat-gpios"
> - Allow re-configuring the input_current_limit via sysfs also when
>   charger auto-detection is enabled
> - Use gpiod interface for initialization as a platform device (nice
>   GPIO setup simplification)
> - Document all newly introduced sysfs nodes
> - Streamlined/fixed/simplified charger state handling as it relates
>   to battery removal/insertion and the associated handling of the
>   input current limit setting
> - Minor simplifications/cleanup
> - Rebased onto git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-
>   power-supply.git (branch "next") and completely retested

It would be useful if you would mark which patches have changed. I
reviewed already the first patch but you did not add my reviewed-by tag.
I suppose something changed... but I can't find the exact reason for
missing review.

Best regards,
Krzysztof


  parent reply	other threads:[~2015-09-28 12:14 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-25 15:54 [PATCH v7 00/15] power: bq24257: Add support for bq24250/bq24251 Andreas Dannenberg
2015-09-25 15:54 ` [PATCH v7 06/15] power: bq24257: Add basic " Andreas Dannenberg
     [not found]   ` <1443196460-26156-7-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-28 13:14     ` Krzysztof Kozlowski
2015-09-28 13:38       ` Andreas Dannenberg
2015-09-25 15:54 ` [PATCH v7 07/15] power: bq24257: Add bit definition for temp sense enable Andreas Dannenberg
2015-09-25 15:54 ` [PATCH v7 15/15] Documentation: power: bq24257: Document exported sysfs entries Andreas Dannenberg
2015-09-28 12:14 ` Krzysztof Kozlowski [this message]
     [not found] ` <1443196460-26156-1-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-25 15:54   ` [PATCH v7 01/15] dt: power: bq24257-charger: Cover additional devices Andreas Dannenberg
     [not found]     ` <1443196460-26156-2-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-28 12:16       ` Krzysztof Kozlowski
2015-09-28 18:16       ` Sebastian Reichel
2015-09-25 15:54   ` [PATCH v7 02/15] power: bq24257: Remove IRQ config through stat-gpios Andreas Dannenberg
     [not found]     ` <1443196460-26156-3-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-28 16:38       ` Sebastian Reichel
2015-09-25 15:54   ` [PATCH v7 03/15] power: bq24257: Streamline input current limit setup Andreas Dannenberg
     [not found]     ` <1443196460-26156-4-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-28 16:53       ` Sebastian Reichel
2015-09-25 15:54   ` [PATCH v7 04/15] power: bq24257: Use managed power supply register Andreas Dannenberg
     [not found]     ` <1443196460-26156-5-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-28 13:10       ` Krzysztof Kozlowski
2015-09-28 17:22       ` Sebastian Reichel
2015-09-25 15:54   ` [PATCH v7 05/15] power: bq24257: Simplify bq24257_power_supply_init() Andreas Dannenberg
     [not found]     ` <1443196460-26156-6-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-28 13:10       ` Krzysztof Kozlowski
2015-09-25 15:54   ` [PATCH v7 08/15] power: bq24257: Allow manual setting of input current limit Andreas Dannenberg
2015-09-29  6:02     ` Krzysztof Kozlowski
2015-09-25 15:54   ` [PATCH v7 09/15] power: bq24257: Add SW-based approach for Power Good determination Andreas Dannenberg
     [not found]     ` <1443196460-26156-10-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-27 20:20       ` Sebastian Reichel
2015-09-28 12:04         ` Andreas Dannenberg
2015-09-28 15:49           ` Andreas Dannenberg
2015-09-28 16:02           ` Sebastian Reichel
2015-09-25 15:54   ` [PATCH v7 10/15] power: bq24257: Add over voltage protection setting support Andreas Dannenberg
2015-09-25 15:54   ` [PATCH v7 11/15] power: bq24257: Add input DPM voltage threshold " Andreas Dannenberg
2015-09-25 15:54   ` [PATCH v7 12/15] power: bq24257: Allow input current limit sysfs access Andreas Dannenberg
2015-09-25 15:54   ` [PATCH v7 13/15] power: bq24257: Add various device-specific sysfs properties Andreas Dannenberg
2015-09-25 15:54   ` [PATCH v7 14/15] power: bq24257: Add platform data based initialization Andreas Dannenberg
     [not found]     ` <1443196460-26156-15-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-28 17:58       ` Sebastian Reichel
2015-09-28 22:50         ` Andreas Dannenberg
2015-09-28 18:19   ` [PATCH v7 00/15] power: bq24257: Add support for bq24250/bq24251 Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56092F29.8060106@samsung.com \
    --to=k.kozlowski@samsung.com \
    --cc=dannenberg@ti.com \
    --cc=dbaryshkov@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=laurentiu.palcu@intel.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=ramakrishna.pallala@intel.com \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.