From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from muin.pair.com (muin.pair.com [209.68.1.55]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id B80A91A002B for ; Mon, 28 Sep 2015 23:26:59 +1000 (AEST) Subject: Re: [PATCH v3 2/3] powerpc/512x: add a device tree binding for LocalPlus Bus FIFO To: alex.popov@linux.com, Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Anatolij Gustschin , Gerhard Sittig , Rob Herring , Grant Likely , Dan Williams , Vinod Koul , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linuxppc-dev@lists.ozlabs.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <1443115737-3948-1-git-send-email-alex.popov@linux.com> <1443115737-3948-3-git-send-email-alex.popov@linux.com> <560492C1.307@tabi.org> <56093F89.1020004@linux.com> From: Timur Tabi Message-ID: <5609401F.3010603@tabi.org> Date: Mon, 28 Sep 2015 08:26:55 -0500 MIME-Version: 1.0 In-Reply-To: <56093F89.1020004@linux.com> Content-Type: text/plain; charset=windows-1252; format=flowed List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Alexander Popov wrote: > I've just followed devicetree/bindings/dma/dma.txt... > This "rx-tx" doesn't mean much but it could show that LocalPlus Bus FIFO > uses a single DMA read-write channel. Should I really drop it? Hmmm, I'm not sure. Is there anything else (besides your driver) that parses this device tree node? dma.txt says this: "The specific strings that can be used are defined in the binding of the DMA client device." So this looks like it's driver-specific, but it is a required property. I guess you should keep it, but I think you should get a second opinion. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH v3 2/3] powerpc/512x: add a device tree binding for LocalPlus Bus FIFO Date: Mon, 28 Sep 2015 08:26:55 -0500 Message-ID: <5609401F.3010603@tabi.org> References: <1443115737-3948-1-git-send-email-alex.popov@linux.com> <1443115737-3948-3-git-send-email-alex.popov@linux.com> <560492C1.307@tabi.org> <56093F89.1020004@linux.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56093F89.1020004-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: alex.popov-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org, Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Anatolij Gustschin , Gerhard Sittig , Rob Herring , Grant Likely , Dan Williams , Vinod Koul , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Alexander Popov wrote: > I've just followed devicetree/bindings/dma/dma.txt... > This "rx-tx" doesn't mean much but it could show that LocalPlus Bus FIFO > uses a single DMA read-write channel. Should I really drop it? Hmmm, I'm not sure. Is there anything else (besides your driver) that parses this device tree node? dma.txt says this: "The specific strings that can be used are defined in the binding of the DMA client device." So this looks like it's driver-specific, but it is a required property. I guess you should keep it, but I think you should get a second opinion. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html