From mboxrd@z Thu Jan 1 00:00:00 1970 From: david.vrabel@citrix.com (David Vrabel) Date: Mon, 28 Sep 2015 14:52:00 +0100 Subject: [Xen-devel] [PATCH] xen/pci: Don't build Xen pci code for ARM and ARM64 In-Reply-To: <1443447044-24985-1-git-send-email-julien.grall@citrix.com> References: <1443447044-24985-1-git-send-email-julien.grall@citrix.com> Message-ID: <56094600.7050508@citrix.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 28/09/15 14:30, Julien Grall wrote: > The PCI support for Xen doesn't compile on ARM/ARM64 when > CONFIG_PCI_MMCONFIG=y: > > drivers/xen/pci.c:31:25: fatal error: asm/pci_x86.h: No such file or > directory > #include > > Although, Xen is not currently involved in PCI management for ARM/ARM64. > There is plan to support it, but it would require some changes in Linux > side. > > For now, introduce a new config options XEN_PCI which will be turned off > for ARM platform. Since PCI_MMCONFIG isn't x86 specific and its use in drivers/xen/pci.c is, can you fix this by changing to #ifdef CONFIG_X86? David From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933947AbbI1Nwt (ORCPT ); Mon, 28 Sep 2015 09:52:49 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:14937 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933822AbbI1Nws (ORCPT ); Mon, 28 Sep 2015 09:52:48 -0400 X-IronPort-AV: E=Sophos;i="5.17,602,1437436800"; d="scan'208";a="306547301" Message-ID: <56094600.7050508@citrix.com> Date: Mon, 28 Sep 2015 14:52:00 +0100 From: David Vrabel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Julien Grall , CC: , , , Robert Richter , David Vrabel , Boris Ostrovsky , Subject: Re: [Xen-devel] [PATCH] xen/pci: Don't build Xen pci code for ARM and ARM64 References: <1443447044-24985-1-git-send-email-julien.grall@citrix.com> In-Reply-To: <1443447044-24985-1-git-send-email-julien.grall@citrix.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/09/15 14:30, Julien Grall wrote: > The PCI support for Xen doesn't compile on ARM/ARM64 when > CONFIG_PCI_MMCONFIG=y: > > drivers/xen/pci.c:31:25: fatal error: asm/pci_x86.h: No such file or > directory > #include > > Although, Xen is not currently involved in PCI management for ARM/ARM64. > There is plan to support it, but it would require some changes in Linux > side. > > For now, introduce a new config options XEN_PCI which will be turned off > for ARM platform. Since PCI_MMCONFIG isn't x86 specific and its use in drivers/xen/pci.c is, can you fix this by changing to #ifdef CONFIG_X86? David