From mboxrd@z Thu Jan 1 00:00:00 1970 From: julien.grall@citrix.com (Julien Grall) Date: Mon, 28 Sep 2015 14:59:18 +0100 Subject: [Xen-devel] [PATCH] xen/pci: Don't build Xen pci code for ARM and ARM64 In-Reply-To: <56094600.7050508@citrix.com> References: <1443447044-24985-1-git-send-email-julien.grall@citrix.com> <56094600.7050508@citrix.com> Message-ID: <560947B6.1030101@citrix.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi David, On 28/09/15 14:52, David Vrabel wrote: > On 28/09/15 14:30, Julien Grall wrote: >> The PCI support for Xen doesn't compile on ARM/ARM64 when >> CONFIG_PCI_MMCONFIG=y: >> >> drivers/xen/pci.c:31:25: fatal error: asm/pci_x86.h: No such file or >> directory >> #include >> >> Although, Xen is not currently involved in PCI management for ARM/ARM64. >> There is plan to support it, but it would require some changes in Linux >> side. >> >> For now, introduce a new config options XEN_PCI which will be turned off >> for ARM platform. > > Since PCI_MMCONFIG isn't x86 specific and its use in drivers/xen/pci.c > is, can you fix this by changing to #ifdef CONFIG_X86? Well, it may be possible that we need this code for ARM/ARM64. >>From the origin thread [1], it wasn't clear what is the correct solution. So I think that disabling the Xen PCI code for now is the right solution. Note, that it's still possible to use PCI in DOM0 on ARM64 platform without this code. Regards, [1] https://lkml.org/lkml/2015/8/6/510 -- Julien Grall From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933951AbbI1OAl (ORCPT ); Mon, 28 Sep 2015 10:00:41 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:12156 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932920AbbI1OAk (ORCPT ); Mon, 28 Sep 2015 10:00:40 -0400 X-IronPort-AV: E=Sophos;i="5.17,602,1437436800"; d="scan'208";a="306549607" Message-ID: <560947B6.1030101@citrix.com> Date: Mon, 28 Sep 2015 14:59:18 +0100 From: Julien Grall User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: David Vrabel , CC: , , , Robert Richter , Boris Ostrovsky , Subject: Re: [Xen-devel] [PATCH] xen/pci: Don't build Xen pci code for ARM and ARM64 References: <1443447044-24985-1-git-send-email-julien.grall@citrix.com> <56094600.7050508@citrix.com> In-Reply-To: <56094600.7050508@citrix.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David, On 28/09/15 14:52, David Vrabel wrote: > On 28/09/15 14:30, Julien Grall wrote: >> The PCI support for Xen doesn't compile on ARM/ARM64 when >> CONFIG_PCI_MMCONFIG=y: >> >> drivers/xen/pci.c:31:25: fatal error: asm/pci_x86.h: No such file or >> directory >> #include >> >> Although, Xen is not currently involved in PCI management for ARM/ARM64. >> There is plan to support it, but it would require some changes in Linux >> side. >> >> For now, introduce a new config options XEN_PCI which will be turned off >> for ARM platform. > > Since PCI_MMCONFIG isn't x86 specific and its use in drivers/xen/pci.c > is, can you fix this by changing to #ifdef CONFIG_X86? Well, it may be possible that we need this code for ARM/ARM64. >>From the origin thread [1], it wasn't clear what is the correct solution. So I think that disabling the Xen PCI code for now is the right solution. Note, that it's still possible to use PCI in DOM0 on ARM64 platform without this code. Regards, [1] https://lkml.org/lkml/2015/8/6/510 -- Julien Grall