From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris.ostrovsky@oracle.com (Boris Ostrovsky) Date: Mon, 28 Sep 2015 10:02:57 -0400 Subject: [Xen-devel] [PATCH] xen/pci: Don't build Xen pci code for ARM and ARM64 In-Reply-To: <560947B6.1030101@citrix.com> References: <1443447044-24985-1-git-send-email-julien.grall@citrix.com> <56094600.7050508@citrix.com> <560947B6.1030101@citrix.com> Message-ID: <56094891.2000409@oracle.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09/28/2015 09:59 AM, Julien Grall wrote: > Hi David, > > On 28/09/15 14:52, David Vrabel wrote: >> On 28/09/15 14:30, Julien Grall wrote: >>> The PCI support for Xen doesn't compile on ARM/ARM64 when >>> CONFIG_PCI_MMCONFIG=y: >>> >>> drivers/xen/pci.c:31:25: fatal error: asm/pci_x86.h: No such file or >>> directory >>> #include >>> >>> Although, Xen is not currently involved in PCI management for ARM/ARM64. >>> There is plan to support it, but it would require some changes in Linux >>> side. >>> >>> For now, introduce a new config options XEN_PCI which will be turned off >>> for ARM platform. >> Since PCI_MMCONFIG isn't x86 specific and its use in drivers/xen/pci.c >> is, can you fix this by changing to #ifdef CONFIG_X86? > Well, it may be possible that we need this code for ARM/ARM64. > > From the origin thread [1], it wasn't clear what is the correct > solution. So I think that disabling the Xen PCI code for now is the > right solution. > > Note, that it's still possible to use PCI in DOM0 on ARM64 platform > without this code. > > Regards, > > [1] https://lkml.org/lkml/2015/8/6/510 > Can we then implement Robert's proposals from that thread and have an arch function for pci_probe? It will be a nop on ARM. (I think that was the only problem here). -boris From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757422AbbI1OFI (ORCPT ); Mon, 28 Sep 2015 10:05:08 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:23878 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754185AbbI1OFH (ORCPT ); Mon, 28 Sep 2015 10:05:07 -0400 Message-ID: <56094891.2000409@oracle.com> Date: Mon, 28 Sep 2015 10:02:57 -0400 From: Boris Ostrovsky User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Julien Grall , David Vrabel , xen-devel@lists.xenproject.org CC: ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, linux-kernel@vger.kernel.org, Robert Richter , linux-arm-kernel@lists.infradead.org Subject: Re: [Xen-devel] [PATCH] xen/pci: Don't build Xen pci code for ARM and ARM64 References: <1443447044-24985-1-git-send-email-julien.grall@citrix.com> <56094600.7050508@citrix.com> <560947B6.1030101@citrix.com> In-Reply-To: <560947B6.1030101@citrix.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/28/2015 09:59 AM, Julien Grall wrote: > Hi David, > > On 28/09/15 14:52, David Vrabel wrote: >> On 28/09/15 14:30, Julien Grall wrote: >>> The PCI support for Xen doesn't compile on ARM/ARM64 when >>> CONFIG_PCI_MMCONFIG=y: >>> >>> drivers/xen/pci.c:31:25: fatal error: asm/pci_x86.h: No such file or >>> directory >>> #include >>> >>> Although, Xen is not currently involved in PCI management for ARM/ARM64. >>> There is plan to support it, but it would require some changes in Linux >>> side. >>> >>> For now, introduce a new config options XEN_PCI which will be turned off >>> for ARM platform. >> Since PCI_MMCONFIG isn't x86 specific and its use in drivers/xen/pci.c >> is, can you fix this by changing to #ifdef CONFIG_X86? > Well, it may be possible that we need this code for ARM/ARM64. > > From the origin thread [1], it wasn't clear what is the correct > solution. So I think that disabling the Xen PCI code for now is the > right solution. > > Note, that it's still possible to use PCI in DOM0 on ARM64 platform > without this code. > > Regards, > > [1] https://lkml.org/lkml/2015/8/6/510 > Can we then implement Robert's proposals from that thread and have an arch function for pci_probe? It will be a nop on ARM. (I think that was the only problem here). -boris