From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH linux-next 0/4] mtd: spi-nor: fix Quad SPI memory support To: , , , , , , , , , , , References: From: Cyrille Pitchen CC: , , , , , , , , Message-ID: <56094A49.7000304@atmel.com> Date: Mon, 28 Sep 2015 16:10:17 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi all, are there other works in progress to enhance the QSPI support inside the spi-nor framework? Do you have any suggestion about what should be done and how to do it? Is there any discussion on this topic? If so, I would be interested in taking part of it so I could synchronize my work with other developers' efforts. Brian, Mark, Marek, with this series I've removed the Atmel QSPI controller driver to focus only on the common spi-nor framework. I will send a dedicated series later for the Atmel QSPI controller once we all agree on an update of the framework API to add support to other QSPI memory manufacturers such as Micron or Macronix. Currently, it looks like the spi-nor framework only works with Spansion memories. For instance, without the patches of this series, I can't use the Micron n25q128a13 embedded on sama5d2 xplained boards. So I hope we will find a way to make it work! Best Regards, Cyrille Le 18/09/2015 17:49, Cyrille Pitchen a écrit : > Hi all, > > this series of patches fixes the QSPI support mostly for Micron and > Macronix memories. There are also some updates for Spansion memories. > There are also many comments to explain the implementation choices based > on the datasheets from memory manufacturers. > > The series was backported to a at91-4.1 kernel then tested on a sama5d2 > xplained board, which embeds a at25df321a memory on a SPI controller and > a Micron n25q128a13 QSPI memory on the new Atmel QSPI controller. > > The at25 memory was used to check non regression on the m25p80 driver > whereas the Micron memory was used to test the fixes of the spi-nor > framework. The driver for the Atmel QSPI controller will be sent in a > dedicated series. > > Best Regards, > > Cyrille > > Cyrille Pitchen (4): > mtd: spi-nor: remove unused read_xfer/write_xfer hooks > mtd: spi-nor: properly detect the memory when it boots in Quad or Dual > mode > mtd: spi-nor: fix Quad SPI mode support for Spansion, Micron and > Macronix > mtd: m25p80: add support of dual and quad spi protocols to all > commands > > drivers/mtd/devices/m25p80.c | 254 ++++++++++--- > drivers/mtd/spi-nor/spi-nor.c | 811 ++++++++++++++++++++++++++++++++++++------ > include/linux/mtd/spi-nor.h | 69 ++-- > 3 files changed, 954 insertions(+), 180 deletions(-) > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyrille Pitchen Subject: Re: [PATCH linux-next 0/4] mtd: spi-nor: fix Quad SPI memory support Date: Mon, 28 Sep 2015 16:10:17 +0200 Message-ID: <56094A49.7000304@atmel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: , , , , , , , , To: , , , , , , , , , , , Return-path: In-Reply-To: Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Hi all, are there other works in progress to enhance the QSPI support inside th= e spi-nor framework? Do you have any suggestion about what should be done and how to do it? Is there any discussion on this topic? If so, I would be interested in = taking part of it so I could synchronize my work with other developers' effort= s. Brian, Mark, Marek, with this series I've removed the Atmel QSPI contro= ller driver to focus only on the common spi-nor framework. I will send a ded= icated series later for the Atmel QSPI controller once we all agree on an upda= te of the framework API to add support to other QSPI memory manufacturers suc= h as Micron or Macronix. Currently, it looks like the spi-nor framework only works with Spansion memories. For instance, without the patches of this series, I can't use= the Micron n25q128a13 embedded on sama5d2 xplained boards. So I hope we will find a way to make it work! Best Regards, Cyrille Le 18/09/2015 17:49, Cyrille Pitchen a =E9crit : > Hi all, >=20 > this series of patches fixes the QSPI support mostly for Micron and > Macronix memories. There are also some updates for Spansion memories. > There are also many comments to explain the implementation choices ba= sed > on the datasheets from memory manufacturers. >=20 > The series was backported to a at91-4.1 kernel then tested on a sama5= d2 > xplained board, which embeds a at25df321a memory on a SPI controller = and > a Micron n25q128a13 QSPI memory on the new Atmel QSPI controller. >=20 > The at25 memory was used to check non regression on the m25p80 driver > whereas the Micron memory was used to test the fixes of the spi-nor > framework. The driver for the Atmel QSPI controller will be sent in a > dedicated series. >=20 > Best Regards, >=20 > Cyrille >=20 > Cyrille Pitchen (4): > mtd: spi-nor: remove unused read_xfer/write_xfer hooks > mtd: spi-nor: properly detect the memory when it boots in Quad or D= ual > mode > mtd: spi-nor: fix Quad SPI mode support for Spansion, Micron and > Macronix > mtd: m25p80: add support of dual and quad spi protocols to all > commands >=20 > drivers/mtd/devices/m25p80.c | 254 ++++++++++--- > drivers/mtd/spi-nor/spi-nor.c | 811 ++++++++++++++++++++++++++++++++= ++++------ > include/linux/mtd/spi-nor.h | 69 ++-- > 3 files changed, 954 insertions(+), 180 deletions(-) >=20 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: cyrille.pitchen@atmel.com (Cyrille Pitchen) Date: Mon, 28 Sep 2015 16:10:17 +0200 Subject: [PATCH linux-next 0/4] mtd: spi-nor: fix Quad SPI memory support In-Reply-To: References: Message-ID: <56094A49.7000304@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi all, are there other works in progress to enhance the QSPI support inside the spi-nor framework? Do you have any suggestion about what should be done and how to do it? Is there any discussion on this topic? If so, I would be interested in taking part of it so I could synchronize my work with other developers' efforts. Brian, Mark, Marek, with this series I've removed the Atmel QSPI controller driver to focus only on the common spi-nor framework. I will send a dedicated series later for the Atmel QSPI controller once we all agree on an update of the framework API to add support to other QSPI memory manufacturers such as Micron or Macronix. Currently, it looks like the spi-nor framework only works with Spansion memories. For instance, without the patches of this series, I can't use the Micron n25q128a13 embedded on sama5d2 xplained boards. So I hope we will find a way to make it work! Best Regards, Cyrille Le 18/09/2015 17:49, Cyrille Pitchen a ?crit : > Hi all, > > this series of patches fixes the QSPI support mostly for Micron and > Macronix memories. There are also some updates for Spansion memories. > There are also many comments to explain the implementation choices based > on the datasheets from memory manufacturers. > > The series was backported to a at91-4.1 kernel then tested on a sama5d2 > xplained board, which embeds a at25df321a memory on a SPI controller and > a Micron n25q128a13 QSPI memory on the new Atmel QSPI controller. > > The at25 memory was used to check non regression on the m25p80 driver > whereas the Micron memory was used to test the fixes of the spi-nor > framework. The driver for the Atmel QSPI controller will be sent in a > dedicated series. > > Best Regards, > > Cyrille > > Cyrille Pitchen (4): > mtd: spi-nor: remove unused read_xfer/write_xfer hooks > mtd: spi-nor: properly detect the memory when it boots in Quad or Dual > mode > mtd: spi-nor: fix Quad SPI mode support for Spansion, Micron and > Macronix > mtd: m25p80: add support of dual and quad spi protocols to all > commands > > drivers/mtd/devices/m25p80.c | 254 ++++++++++--- > drivers/mtd/spi-nor/spi-nor.c | 811 ++++++++++++++++++++++++++++++++++++------ > include/linux/mtd/spi-nor.h | 69 ++-- > 3 files changed, 954 insertions(+), 180 deletions(-) > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyrille Pitchen Subject: Re: [PATCH linux-next 0/4] mtd: spi-nor: fix Quad SPI memory support Date: Mon, 28 Sep 2015 16:10:17 +0200 Message-ID: <56094A49.7000304@atmel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, beanhuo-AL4WhLSQfzjQT0dZR+AlfA@public.gmane.org, juhosg-p3rKhJxN3npAfugRpC6u6w@public.gmane.org, marex-ynQEQJNshbs@public.gmane.org, ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org, jogo-p3rKhJxN3npAfugRpC6u6w@public.gmane.org, jteki-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hi all, are there other works in progress to enhance the QSPI support inside th= e spi-nor framework? Do you have any suggestion about what should be done and how to do it? Is there any discussion on this topic? If so, I would be interested in = taking part of it so I could synchronize my work with other developers' effort= s. Brian, Mark, Marek, with this series I've removed the Atmel QSPI contro= ller driver to focus only on the common spi-nor framework. I will send a ded= icated series later for the Atmel QSPI controller once we all agree on an upda= te of the framework API to add support to other QSPI memory manufacturers suc= h as Micron or Macronix. Currently, it looks like the spi-nor framework only works with Spansion memories. For instance, without the patches of this series, I can't use= the Micron n25q128a13 embedded on sama5d2 xplained boards. So I hope we will find a way to make it work! Best Regards, Cyrille Le 18/09/2015 17:49, Cyrille Pitchen a =E9crit : > Hi all, >=20 > this series of patches fixes the QSPI support mostly for Micron and > Macronix memories. There are also some updates for Spansion memories. > There are also many comments to explain the implementation choices ba= sed > on the datasheets from memory manufacturers. >=20 > The series was backported to a at91-4.1 kernel then tested on a sama5= d2 > xplained board, which embeds a at25df321a memory on a SPI controller = and > a Micron n25q128a13 QSPI memory on the new Atmel QSPI controller. >=20 > The at25 memory was used to check non regression on the m25p80 driver > whereas the Micron memory was used to test the fixes of the spi-nor > framework. The driver for the Atmel QSPI controller will be sent in a > dedicated series. >=20 > Best Regards, >=20 > Cyrille >=20 > Cyrille Pitchen (4): > mtd: spi-nor: remove unused read_xfer/write_xfer hooks > mtd: spi-nor: properly detect the memory when it boots in Quad or D= ual > mode > mtd: spi-nor: fix Quad SPI mode support for Spansion, Micron and > Macronix > mtd: m25p80: add support of dual and quad spi protocols to all > commands >=20 > drivers/mtd/devices/m25p80.c | 254 ++++++++++--- > drivers/mtd/spi-nor/spi-nor.c | 811 ++++++++++++++++++++++++++++++++= ++++------ > include/linux/mtd/spi-nor.h | 69 ++-- > 3 files changed, 954 insertions(+), 180 deletions(-) >=20 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html